Skip to content

Add data descriptions for nobo_hub config and options flows #168723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joostlek merged 2 commits into from
Apr 21, 2026
Merged

Add data descriptions for nobo_hub config and options flows #168723

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05d1efe
Add data descriptions for nobo_hub config and options flows
oyvindwe Apr 21, 2026
f9b016c
Address Copilot review feedback
oyvindwe Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion homeassistant/components/nobo_hub/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,28 @@
"ip_address": "[%key:common::config_flow::data::ip%]",
"serial": "Serial number (12 digits)"
},
"data_description": {
"ip_address": "The IP address of your Nobø Ecohub.",
"serial": "The full 12-digit serial number printed on the back of your Nobø Ecohub."
},
"description": "Configure a Nobø Ecohub not discovered on your local network. If your hub is on another network, you can still connect to it by entering the complete serial number (12 digits) and its IP address."
},
"selected": {
"data": {
"serial_suffix": "Serial number suffix (3 digits)"
},
"data_description": {
"serial_suffix": "The last 3 digits of the serial number printed on the back of your Nobø Ecohub."
},
"description": "Configuring {hub}.\r\rTo connect to the hub, you need to enter the last 3 digits of the hub's serial number."
},
"user": {
"data": {
"device": "Discovered hubs"
},
"data_description": {
"device": "Select the Nobø Ecohub discovered on your local network, or choose manual entry."
},
"description": "Select Nobø Ecohub to configure."
}
}
Expand Down Expand Up @@ -64,7 +74,10 @@
"data": {
"override_type": "Override type"
},
"description": "Select override type \"Now\" to end override on next week profile change."
"data_description": {
"override_type": "Select \"Now\" to end a global override on the next week profile change, or \"Constant\" to keep it until manually cleared."
Copy link
Copy Markdown
Contributor

@NoRi2909 NoRi2909 Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those options "Now" and "Constant" don't have translations, yet.

So when they remain English in the UI and need to be typed in, they should be enclosed in backticks.
Otherwise we translators (and Google Translate / Deepl) do translate them causing a mismatch.

Copy link
Copy Markdown
Contributor Author

@oyvindwe oyvindwe Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've addressed this in the follow-up PR #168740

I'll also look into translating Now and Constant.

Copy link
Copy Markdown
Contributor Author

@oyvindwe oyvindwe Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations for "Now" and "Constant" added in PR #168752

},
"description": "Select \"Now\" to end a global override on the next week profile change, or \"Constant\" to keep it until manually cleared."
Copy link
Copy Markdown
Contributor

@NoRi2909 NoRi2909 Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is identical to the field's data_description so it would be duplicated in the UI?

Copy link
Copy Markdown
Contributor Author

@oyvindwe oyvindwe Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that was my (and Claude's) concern as well, but I commented post-merge as well.

I've addressed this in the follow-up PR #168740

}
}
}
Expand Down