Fix nobo_hub override type description#168740
Merged
Merged
Conversation
- The override type applies to all overrides, not only global ones. - Backtick `Now` and `Constant` so translation tools don't localize them. - Shorten the step description so it no longer duplicates the field help.
home-assistant
Bot
added
bugfix
cla-signed
integration: nobo_hub
small-pr
Contributor
|
Hey there @echoromeo, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
21 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Nobø Ecohub integration’s options-flow copy to better match the behavior of the override type option and avoid translation/localization issues for the literal option values.
Changes:
- Wraps the literal option values
NowandConstantin backticks in the field help text. - Clarifies that the override type setting applies to overrides generally (not only global overrides).
- Shortens the step description to avoid duplicating the field’s help text.
joostlek
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Follow up to post-merger comments in PR #168723 :
NowandConstantso translation tools don't localize them.Also corrects an issue introduced by Copilot I didn't catch:
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: