Add data descriptions for nobo_hub config and options flows#168723
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
home-assistant
Bot
added
cla-signed
code-quality
integration: nobo_hub
small-pr
|
Hey there @echoromeo, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull request overview
This PR improves the Nobø Ecohub (nobo_hub) integration’s UX by adding data_description help text for fields in the config flow (manual/selected/user) and options flow, supporting the integration’s move toward Bronze quality scale.
Changes:
- Add field-level
data_descriptionentries for config flow steps (manual,selected,user). - Add field-level
data_descriptionfor the options flowoverride_typefield.
Applied both suggestions. Claude had a comment though:
|
|
I think we can pick the most logical one, no need to duplicate |
NoRi2909
left a comment
NoRi2909
left a comment
There was a problem hiding this comment.
Noticed post-merge in Lokalise:
| }, | ||
| "description": "Select override type \"Now\" to end override on next week profile change." | ||
| "data_description": { | ||
| "override_type": "Select \"Now\" to end a global override on the next week profile change, or \"Constant\" to keep it until manually cleared." |
There was a problem hiding this comment.
Those options "Now" and "Constant" don't have translations, yet.
So when they remain English in the UI and need to be typed in, they should be enclosed in backticks.
Otherwise we translators (and Google Translate / Deepl) do translate them causing a mismatch.
There was a problem hiding this comment.
I've addressed this in the follow-up PR #168740
I'll also look into translating Now and Constant.
There was a problem hiding this comment.
Translations for "Now" and "Constant" added in PR #168752
| "data_description": { | ||
| "override_type": "Select \"Now\" to end a global override on the next week profile change, or \"Constant\" to keep it until manually cleared." | ||
| }, | ||
| "description": "Select \"Now\" to end a global override on the next week profile change, or \"Constant\" to keep it until manually cleared." |
There was a problem hiding this comment.
This is identical to the field's data_description so it would be duplicated in the UI?
There was a problem hiding this comment.
Yes, that was my (and Claude's) concern as well, but I commented post-merge as well.
I've addressed this in the follow-up PR #168740
Proposed change
Context: This is PR 4 of 6 to get nobo_hub to the Bronze level on the quality scale.
Add data descriptions for nobo_hub config and options flows.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: