Skip to content

Revert "Exempt pyparsing from license check (#159605)"#159631

Merged
thecode merged 1 commit into
home-assistant:devfrom
cdce8p:revert-pyparsing-license
Dec 23, 2025
Merged

Revert "Exempt pyparsing from license check (#159605)"#159631
thecode merged 1 commit into
home-assistant:devfrom
cdce8p:revert-pyparsing-license

Conversation

@cdce8p
Copy link
Copy Markdown
Member

@cdce8p cdce8p commented Dec 23, 2025

Proposed change

Revert #159605

Pyparsing v3.3.1 was released a few hours ago. It fixed the license metadata.
https://github.com/pyparsing/pyparsing/releases/tag/3.3.1
pyparsing/pyparsing@3.3.0...3.3.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@cdce8p cdce8p requested a review from a team as a code owner December 23, 2025 10:00
@home-assistant home-assistant Bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels Dec 23, 2025
Copy link
Copy Markdown
Member

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One small comment about the cache version.

Comment thread .github/workflows/ci.yaml
@thecode thecode merged commit 7a82aa4 into home-assistant:dev Dec 23, 2025
123 of 124 checks passed
@thecode thecode mentioned this pull request Dec 23, 2025
21 tasks
@cdce8p cdce8p deleted the revert-pyparsing-license branch December 23, 2025 10:59
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants