Skip to content

Bump python-roborock to 3.20.1#159621

Merged
thecode merged 2 commits into
home-assistant:devfrom
allenporter:roborock-bump
Dec 23, 2025
Merged

Bump python-roborock to 3.20.1#159621
thecode merged 2 commits into
home-assistant:devfrom
allenporter:roborock-bump

Conversation

@allenporter
Copy link
Copy Markdown
Contributor

Proposed change

Bump python-roborock to 3.20.1
Changes: Python-roborock/python-roborock@v3.19.0...v3.20.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@allenporter allenporter added this to the 2025.12.5 milestone Dec 23, 2025
Copilot AI review requested due to automatic review settings December 23, 2025 01:20
@home-assistant home-assistant Bot added bugfix cla-signed dependency Pull requests marked as a dependency upgrade integration: roborock small-pr PRs with less than 30 lines. by-code-owner Quality Scale: silver labels Dec 23, 2025
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the python-roborock dependency from version 3.19.0 to 3.20.1 to fix issue #159334. The update is applied consistently across all dependency files and includes bug fixes from the upstream library.

Key changes:

  • Bump python-roborock library version from 3.19.0 to 3.20.1
  • Update applied to all dependency files and the integration manifest

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
requirements_all.txt Updated python-roborock version to 3.20.1
requirements_test_all.txt Updated python-roborock version to 3.20.1
homeassistant/components/roborock/manifest.json Updated python-roborock version to 3.20.1 in the integration requirements

The changes are straightforward and correctly applied. The version number is consistent across all three files, which is the expected pattern for dependency upgrades in Home Assistant. No code changes were required in the integration itself, indicating this is a drop-in replacement that fixes bugs in the underlying library.

Copy link
Copy Markdown
Member

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the diagnostics snapshot still needs to be updated

@allenporter
Copy link
Copy Markdown
Contributor Author

Looks like the diagnostics snapshot still needs to be updated

Thanks, updated.

@thecode
Copy link
Copy Markdown
Member

thecode commented Dec 23, 2025

There is a failed test due to license which was resolved - https://github.com/home-assistant/core/actions/runs/20451192438/job/58764598095?pr=159621#step:7:29

EDIT: Something was merged in a previous PR which broke CI, not this PR

@thecode
Copy link
Copy Markdown
Member

thecode commented Dec 23, 2025

CI failure is fixed at #159631

@thecode thecode merged commit 8361d65 into home-assistant:dev Dec 23, 2025
65 of 67 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to decode message from Roborock

5 participants