Skip to content

Exempt pyparsing from license check#159605

Merged
MartinHjelmare merged 2 commits into
home-assistant:devfrom
TheJulianJES:tjj/licenses_exceptions_pyparsing
Dec 22, 2025
Merged

Exempt pyparsing from license check#159605
MartinHjelmare merged 2 commits into
home-assistant:devfrom
TheJulianJES:tjj/licenses_exceptions_pyparsing

Conversation

@TheJulianJES
Copy link
Copy Markdown
Member

Proposed change

This adds pyparsing to the list of license exceptions, as they changed their license identifier in the latest version to something we aren't detecting. It's likely something that should be fixed on their side at some point. For now, we should work around it to unblock CI on dev.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings December 22, 2025 17:03
@TheJulianJES TheJulianJES requested a review from a team as a code owner December 22, 2025 17:03
@home-assistant home-assistant Bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels Dec 22, 2025
@TheJulianJES TheJulianJES marked this pull request as draft December 22, 2025 17:13
@TheJulianJES
Copy link
Copy Markdown
Member Author

Cache version needs to be bumped as well. Will do in a second.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds pyparsing to the license check exceptions list to unblock CI on the dev branch. The pyparsing library recently changed its license identifier format, which the automated license detection system no longer recognizes, even though it remains an MIT-licensed package.

Key changes:

  • Added "pyparsing" entry to the EXCEPTIONS set with a comment indicating it uses MIT license

Comment thread script/licenses.py
"sharp_aquos_rc", # https://github.com/jmoore987/sharp_aquos_rc/pull/14
"tapsaff", # https://github.com/bazwilliams/python-taps-aff/pull/5
"ujson", # https://github.com/ultrajson/ultrajson/blob/main/LICENSE.txt
"pyparsing", # MIT
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment should provide more context about why pyparsing is in the exceptions list. Consider adding a reference to the upstream commit that changed the license identifier or a note explaining that the license identifier format is not being detected correctly. For example: "# MIT - license identifier format not detected (pyparsing/pyparsing@085fa0d)" This would help future maintainers understand why this exception exists and when it might be safe to remove.

Suggested change
"pyparsing", # MIT
"pyparsing", # MIT - license identifier format not detected (pyparsing/pyparsing@085fa0d)

Copilot uses AI. Check for mistakes.
@TheJulianJES TheJulianJES marked this pull request as ready for review December 22, 2025 17:33
@MartinHjelmare MartinHjelmare merged commit fe0c92b into home-assistant:dev Dec 22, 2025
67 checks passed
cdce8p added a commit to cdce8p/ha-core that referenced this pull request Dec 23, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants