Exempt pyparsing from license check#159605
Conversation
|
Cache version needs to be bumped as well. Will do in a second. |
There was a problem hiding this comment.
Pull request overview
This PR adds pyparsing to the license check exceptions list to unblock CI on the dev branch. The pyparsing library recently changed its license identifier format, which the automated license detection system no longer recognizes, even though it remains an MIT-licensed package.
Key changes:
- Added "pyparsing" entry to the EXCEPTIONS set with a comment indicating it uses MIT license
| "sharp_aquos_rc", # https://github.com/jmoore987/sharp_aquos_rc/pull/14 | ||
| "tapsaff", # https://github.com/bazwilliams/python-taps-aff/pull/5 | ||
| "ujson", # https://github.com/ultrajson/ultrajson/blob/main/LICENSE.txt | ||
| "pyparsing", # MIT |
There was a problem hiding this comment.
The comment should provide more context about why pyparsing is in the exceptions list. Consider adding a reference to the upstream commit that changed the license identifier or a note explaining that the license identifier format is not being detected correctly. For example: "# MIT - license identifier format not detected (pyparsing/pyparsing@085fa0d)" This would help future maintainers understand why this exception exists and when it might be safe to remove.
| "pyparsing", # MIT | |
| "pyparsing", # MIT - license identifier format not detected (pyparsing/pyparsing@085fa0d) |
Proposed change
This adds pyparsing to the list of license exceptions, as they changed their license identifier in the latest version to something we aren't detecting. It's likely something that should be fixed on their side at some point. For now, we should work around it to unblock CI on
dev.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: