Skip to content

Exempt pyparsing from license check #159605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 2 commits into from
Dec 22, 2025
Merged

Exempt pyparsing from license check #159605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be680b9
Exempt pyparsing from license check
TheJulianJES Dec 22, 2025
3de7489
Bump CI workflow `CACHE_VERSION`
TheJulianJES Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ on:
type: boolean

env:
CACHE_VERSION: 2
CACHE_VERSION: 3
UV_CACHE_VERSION: 1
MYPY_CACHE_VERSION: 1
HA_SHORT_VERSION: "2026.1"
Expand Down
1 change: 1 addition & 0 deletions script/licenses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ def from_dict(cls, data: PackageMetadata) -> PackageDefinition:
"sharp_aquos_rc", # https://github.com/jmoore987/sharp_aquos_rc/pull/14
"tapsaff", # https://github.com/bazwilliams/python-taps-aff/pull/5
"ujson", # https://github.com/ultrajson/ultrajson/blob/main/LICENSE.txt
"pyparsing", # MIT
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment should provide more context about why pyparsing is in the exceptions list. Consider adding a reference to the upstream commit that changed the license identifier or a note explaining that the license identifier format is not being detected correctly. For example: "# MIT - license identifier format not detected (pyparsing/pyparsing@085fa0d)" This would help future maintainers understand why this exception exists and when it might be safe to remove.

Suggested change
"pyparsing", # MIT
"pyparsing", # MIT - license identifier format not detected (pyparsing/pyparsing@085fa0d)

Copilot uses AI. Check for mistakes.
}

# fmt: off
Expand Down
Loading