Rename DALI Center to Sunricher DALI#155865
Conversation
|
Hey there @niracler, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull Request Overview
This PR renames the integration from "sunricher_dali_center" to "sunricher_dali", reflecting a domain name change throughout the codebase. The rename affects the integration name, domain identifier, and all associated references across code, tests, documentation strings, and generated configuration files.
Key Changes
- Domain renamed from "sunricher_dali_center" to "sunricher_dali"
- Integration name changed from "DALI Center" to "Sunricher DALI"
- All references to "DALI Center" updated to "Sunricher DALI" in docstrings and comments
Reviewed Changes
Copilot reviewed 18 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/sunricher_dali/manifest.json | Updated domain and integration name |
| homeassistant/components/sunricher_dali/const.py | Created with new domain constant |
| homeassistant/components/sunricher_dali_center/const.py | Removed old domain constants file |
| homeassistant/components/sunricher_dali/init.py | Updated docstrings to reflect new name |
| homeassistant/components/sunricher_dali/config_flow.py | Updated docstrings to reflect new name |
| homeassistant/components/sunricher_dali/light.py | Updated docstrings to reflect new name |
| homeassistant/components/sunricher_dali/types.py | Updated docstrings to reflect new name |
| homeassistant/components/sunricher_dali/strings.json | Updated user-facing strings with new name, removed title fields |
| homeassistant/components/sunricher_dali/quality_scale.yaml | Added quality scale tracking file |
| tests/components/sunricher_dali/init.py | Created test module docstring |
| tests/components/sunricher_dali_center/init.py | Removed old test module |
| tests/components/sunricher_dali/*.py | Updated all test imports and patches |
| tests/components/sunricher_dali/conftest.py | Updated test fixture imports and patches |
| homeassistant/generated/*.json | Updated generated configuration files |
| requirements*.txt | Updated dependency comments |
| CODEOWNERS | Updated ownership paths |
Co-authored-by: Franck Nijhof <git@frenck.dev>
Breaking change
Proposed change
Rename the DALI Center integration to Sunricher DALI. DALI Center is desktop software by Sunricher that is not involved with this integration. This integration only works with a DALI gateway by Sunricher.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: