Skip to content

Rename DALI Center to Sunricher DALI#155865

Merged
frenck merged 2 commits into
devfrom
sunricher-rename
Nov 5, 2025
Merged

Rename DALI Center to Sunricher DALI#155865
frenck merged 2 commits into
devfrom
sunricher-rename

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Nov 5, 2025

Breaking change

Proposed change

Rename the DALI Center integration to Sunricher DALI. DALI Center is desktop software by Sunricher that is not involved with this integration. This integration only works with a DALI gateway by Sunricher.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Nov 5, 2025

Hey there @niracler, mind taking a look at this pull request as it has been labeled with an integration (sunricher_dali_center) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sunricher_dali_center can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sunricher_dali_center Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread homeassistant/components/sunricher_dali/const.py
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the integration from "sunricher_dali_center" to "sunricher_dali", reflecting a domain name change throughout the codebase. The rename affects the integration name, domain identifier, and all associated references across code, tests, documentation strings, and generated configuration files.

Key Changes

  • Domain renamed from "sunricher_dali_center" to "sunricher_dali"
  • Integration name changed from "DALI Center" to "Sunricher DALI"
  • All references to "DALI Center" updated to "Sunricher DALI" in docstrings and comments

Reviewed Changes

Copilot reviewed 18 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
homeassistant/components/sunricher_dali/manifest.json Updated domain and integration name
homeassistant/components/sunricher_dali/const.py Created with new domain constant
homeassistant/components/sunricher_dali_center/const.py Removed old domain constants file
homeassistant/components/sunricher_dali/init.py Updated docstrings to reflect new name
homeassistant/components/sunricher_dali/config_flow.py Updated docstrings to reflect new name
homeassistant/components/sunricher_dali/light.py Updated docstrings to reflect new name
homeassistant/components/sunricher_dali/types.py Updated docstrings to reflect new name
homeassistant/components/sunricher_dali/strings.json Updated user-facing strings with new name, removed title fields
homeassistant/components/sunricher_dali/quality_scale.yaml Added quality scale tracking file
tests/components/sunricher_dali/init.py Created test module docstring
tests/components/sunricher_dali_center/init.py Removed old test module
tests/components/sunricher_dali/*.py Updated all test imports and patches
tests/components/sunricher_dali/conftest.py Updated test fixture imports and patches
homeassistant/generated/*.json Updated generated configuration files
requirements*.txt Updated dependency comments
CODEOWNERS Updated ownership paths

Comment thread tests/components/sunricher_dali/__init__.py
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @balloob 👍

../Frenck

@frenck frenck merged commit a257b5c into dev Nov 5, 2025
62 of 63 checks passed
@frenck frenck deleted the sunricher-rename branch November 5, 2025 18:15
frenck added a commit that referenced this pull request Nov 5, 2025
Co-authored-by: Franck Nijhof <git@frenck.dev>
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants