Skip to content

Add branding for custom integration dali_center#8363

Merged
frenck merged 4 commits into
home-assistant:masterfrom
niracler:fix/dali-center-soft-link
Nov 7, 2025
Merged

Add branding for custom integration dali_center#8363
frenck merged 4 commits into
home-assistant:masterfrom
niracler:fix/dali-center-soft-link

Conversation

@niracler
Copy link
Copy Markdown
Contributor

@niracler niracler commented Nov 6, 2025

Proposed change

Since the domain of the core integration was changed, we need to add branding for custom integration dali_center

home-assistant/core#155865

We are still actively using the dali_center custom integration. The current core integration only includes about one-fifth of the features from our custom integration. Once we gradually migrate the remaining features to the core integration and users have moved over, we will consider removing the custom symlink.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
    • I've added a link to my custom integration repository in the PR description
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom integrations should not use symlinks.

See also the README in this repository.

Custom integrations needs to provide their own branding.

../Frenck

@home-assistant home-assistant Bot marked this pull request as draft November 7, 2025 08:08
@home-assistant
Copy link
Copy Markdown

home-assistant Bot commented Nov 7, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@niracler niracler changed the title Fix symbolic link from core sunricher_dali custom dali_center Add branding for custom integration dali_center Nov 7, 2025
@niracler
Copy link
Copy Markdown
Contributor Author

niracler commented Nov 7, 2025

Custom integrations should not use symlinks.

See also the README in this repository.

Custom integrations needs to provide their own branding.

../Frenck

Fixed. Replaced symlink with actual brand files.

@niracler niracler marked this pull request as ready for review November 7, 2025 08:29
@home-assistant home-assistant Bot requested a review from frenck November 7, 2025 08:29
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @niracler 👍

../Frenck

@frenck frenck merged commit 6651e1e into home-assistant:master Nov 7, 2025
5 checks passed
adamoutler pushed a commit to adamoutler/brands that referenced this pull request Nov 30, 2025
bharat pushed a commit to bharat/homeassistant-brands that referenced this pull request Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants