Skip to content

Rename the sunricher integration#41629

Merged
frenck merged 1 commit into
nextfrom
rename-sunricher
Nov 5, 2025
Merged

Rename the sunricher integration#41629
frenck merged 1 commit into
nextfrom
rename-sunricher

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Nov 5, 2025

Proposed change

Docs for home-assistant/core#155865

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Copilot AI review requested due to automatic review settings November 5, 2025 17:24
@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Nov 5, 2025
@balloob balloob added this to the 2025.11 milestone Nov 5, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 5, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit d2b80b8
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/690b88503df5b100084dae5d
😎 Deploy Preview https://deploy-preview-41629--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Sunricher DALI integration documentation to standardize naming from "DALI Center" to "Sunricher DALI" throughout the document. The changes ensure consistency between the integration's domain name (sunricher_dali) and its displayed title in the documentation.

  • Updated the title and all references from "DALI Center" to "Sunricher DALI"
  • Removed the "Supported devices" section that listed specific DALI device types
  • Minor formatting cleanup (removed extra blank lines)
Comments suppressed due to low confidence (1)

source/_integrations/sunricher_dali.markdown:21

  • The removal of the 'Supported devices' section eliminates valuable information about DALI device compatibility (DT6, DT8 Tc, RGB, XY, RGBW, RGBWA). While this information is partially mentioned later in the 'Lights' section, it would be clearer to retain the explicit 'Supported devices' section per the integration documentation template structure, or ensure all device types are clearly listed in one place.

Copy link
Copy Markdown
Contributor

@silamon silamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to keep the supported devices section. They mention what devices are supported through this gateway (and more important which ones not)

@home-assistant home-assistant Bot marked this pull request as draft November 5, 2025 18:08
@home-assistant
Copy link
Copy Markdown

home-assistant Bot commented Nov 5, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Nov 5, 2025

The wording does not make it sound like only those devices are supported. It uses the word "including".

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Nov 5, 2025

Like it mentions it supports DALI lightning devices, which makes sense, because it's a DALI gateway that's supported.

@silamon silamon added the awaits-parent Awaits the merge of an parent PR label Nov 5, 2025
@frenck frenck marked this pull request as ready for review November 5, 2025 18:26
@home-assistant home-assistant Bot requested a review from silamon November 5, 2025 18:26
@frenck frenck merged commit 0d53642 into next Nov 5, 2025
15 checks passed
@home-assistant home-assistant Bot removed the awaits-parent Awaits the merge of an parent PR label Nov 5, 2025
@frenck frenck deleted the rename-sunricher branch November 5, 2025 18:26
balloob added a commit that referenced this pull request Nov 5, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants