Added support to HTTPS URLs on SynologyDSM#15270
Conversation
homeassistant
added
cla-signed
platform: sensor.synologydsm
small-pr
ghost
added
the
|
|
||
| try: | ||
| self._api = SynologyDSM(host, port, username, password) | ||
| self._api = SynologyDSM(host, port, username, password, use_https=use_ssl) |
tchellomello
force-pushed
the
synology_https
branch
from
e353f10 to
26f40f2
Compare
tchellomello
changed the title
| PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({ | ||
| vol.Required(CONF_HOST): cv.string, | ||
| vol.Optional(CONF_PORT, default=DEFAULT_PORT): cv.port, | ||
| vol.Optional(CONF_SSL, default=False): cv.boolean, |
There was a problem hiding this comment.
@pvizeli the default port listed on the component is 5000 which is a not HTTPS. If you set the default to True, then we will need to change the default port to 5001 and that will be a breaking change. In this case, do you still want that set to True? I can make the changes if that is the case, but we will need to release a small note due to the breaking change.
Please let me know your thoughts.
There was a problem hiding this comment.
Yeah, we do default the best possible solution and if a user don't want be save, he need that downgrade in config. In that case, set default port to 5001.
There was a problem hiding this comment.
Sounds good. I'll make sure to update the docs and update the PR soon.
|
@pvizeli code and docs updated. Thanks!! 👍 |
* Added support to HTTPS URLs on SynologyDSM * Bumped python-synology to 0.1.1 * Makes lint happy * Added attribution to Synology and fixed 3rd library version * Fixed requirements_all.txt * Makes SynologyDSM defaults to 5001 using SSL
* Added support to HTTPS URLs on SynologyDSM * Bumped python-synology to 0.1.1 * Makes lint happy * Added attribution to Synology and fixed 3rd library version * Fixed requirements_all.txt * Makes SynologyDSM defaults to 5001 using SSL
4 participants
Description:
Added support to HTTPS URLs on Synology DSM
[x] 3rd party PR approved ProtoThis/python-synology#6
Related issue (if applicable): fixes #15269
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5650
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: