Added support to HTTPS URLs and for special characters in the username or password#6
Merged
Conversation
This was referenced Jul 2, 2018
Contributor
Author
|
@StaticCube I've already created a PR home-assistant/core#15270 waiting for this fix. Please let me know your thoughts 👍 |
Owner
|
Looks really cool will do a checkout and let you know, |
Contributor
Author
|
Thanks @StaticCube ! |
Quentame
pushed a commit
to Quentame/python-synology
that referenced
this pull request
Aug 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added support to HTTPS URLs and also support special characters in the user's password such as '#' or '!'
Here below an example of using HTTPS and encoding a password
See also: