Add TP-Link Archer C20 device tracking support#11827
Add TP-Link Archer C20 device tracking support#11827btomer wants to merge 1 commit intohome-assistant:devfrom
Conversation
amelchio
left a comment
There was a problem hiding this comment.
There is a HA rule that device specific protocol information must be handled by an external PyPI library. Even if the TP-Link device tracker is not a great example of that, a PR making it even worse is unlikely to get accepted at this time.
It seems that someone has already created such a library, from the HA code even: https://github.com/ericpignet/pytplinkrouter
So if you can get your change added to pytplinkrouter instead and then modify this device tracker to use the library, that would be a great contribution!
|
Hi all, Eric |
|
If you are willing to maintain your library for the long haul, changing now makes sense to me. |
|
Please provide a PR to use |
Description:
Added device_tracker support for my TP-Link Archer C20 router.
Tested on firmware 0.9.1 4.0 v0044.0 Build 160427.
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests pass(There are no new external dependencies and no new files)