Added support for TP-Link Archer C50 V3 BR Version by MelkyFB-zz · Pull Request #13525 · home-assistant/core

MelkyFB-zz · 2018-03-28T19:51:38Z

Description:

Pull request in home-assistant.github.io
The tplink.py was not working for this model of router, I tested with my Brazilian Version, maybe it works with Europe Version or even with other other Hardware versions, not only v3.

Checklist:

The code change is tested and works locally.
Local tests pass with tox.

houndci-bot · 2018-03-28T19:51:48Z

homeassistant/components/device_tracker/tplink.py

+        referer = 'http://{}/'.format(self.host)
+        cookie = 'Authorization=Basic {}'.format(self.credentials)
+
+        payload = '[LAN_HOST_ENTRY#0,0,0,0,0,0#0,0,0,0,0,0]0,4\r\nleaseTimeRemaining\r\nMACAddress\r\nhostName\r\nIPAddress\r\n'


line too long (128 > 79 characters)

houndci-bot · 2018-03-28T19:51:48Z

homeassistant/components/device_tracker/tplink.py

+
+        mac_results = []
+
+        #CHECK DHCP CLIENT LIST


block comment should start with '# '

houndci-bot · 2018-03-28T19:51:49Z

homeassistant/components/device_tracker/tplink.py

+        # Create the authorization cookie.
+        cookie = 'Authorization=Basic {}'.format(self.credentials)
+
+        response = requests.get(url, headers={COOKIE: cookie})


local variable 'response' is assigned to but never used

houndci-bot · 2018-03-28T19:51:49Z

homeassistant/components/device_tracker/tplink.py

+        _LOGGER.info("Retrieving auth tokens...")
+        url = 'http://{}/'.format(self.host)
+
+        credentials = '{}:{}'.format(self.username, self.password).encode('utf')


line too long (80 > 79 characters)

houndci-bot · 2018-03-28T19:51:49Z

homeassistant/components/device_tracker/tplink.py

+        self.token = ''
+        #had to rewrite due c50 responds with colon mac instead of dash
+        self.parse_macs_c50 = re.compile('[0-9A-F]{2}:[0-9A-F]{2}:[0-9A-F]{2}:' +
+                                     '[0-9A-F]{2}:[0-9A-F]{2}:[0-9A-F]{2}')


continuation line under-indented for visual indent

houndci-bot · 2018-03-28T19:51:49Z

homeassistant/components/device_tracker/tplink.py

+        self.credentials = ''
+        self.token = ''
+        #had to rewrite due c50 responds with colon mac instead of dash
+        self.parse_macs_c50 = re.compile('[0-9A-F]{2}:[0-9A-F]{2}:[0-9A-F]{2}:' +


line too long (81 > 79 characters)

houndci-bot · 2018-03-28T19:51:49Z

homeassistant/components/device_tracker/tplink.py

+        """Initialize the scanner."""
+        self.credentials = ''
+        self.token = ''
+        #had to rewrite due c50 responds with colon mac instead of dash


block comment should start with '# '

houndci-bot · 2018-03-28T19:51:49Z

homeassistant/components/device_tracker/tplink.py

        self.stok = ''
        self.sysauth = ''

+class TplinkArcherC50DeviceScanner(TplinkDeviceScanner):


expected 2 blank lines, found 1

homeassistant · 2018-03-28T19:56:49Z

Hi @melkyfb,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

houndci-bot · 2018-03-28T19:56:57Z

homeassistant/components/device_tracker/tplink.py

+        cookie = 'Authorization=Basic {}'.format(self.credentials)
+
+        payload = '[LAN_HOST_ENTRY#0,0,0,0,0,0#0,0,0,0,0,0]0,4\r\n' +
+                  'leaseTimeRemaining\r\nMACAddress\r\nhostName\r\nIPAddress\r\n'


indentation is not a multiple of four
unexpected indentation
line too long (81 > 79 characters)

houndci-bot · 2018-03-28T19:56:57Z

homeassistant/components/device_tracker/tplink.py

+        url = 'http://{}/'.format(self.host)
+
+        credentials = '{}:{}'.format(self.username, \
+            self.password).encode('utf')


continuation line under-indented for visual indent

houndci-bot · 2018-03-28T19:56:57Z

homeassistant/components/device_tracker/tplink.py

+        _LOGGER.info("Retrieving auth tokens...")
+        url = 'http://{}/'.format(self.host)
+
+        credentials = '{}:{}'.format(self.username, \


the backslash is redundant between brackets

houndci-bot · 2018-03-28T19:56:58Z

homeassistant/components/device_tracker/tplink.py

+        self.token = ''
+        # I had to rewrite due c50 responds with colon mac instead of dash
+        self.parse_macs_c50 = 
+            re.compile('[0-9A-F]{2}:[0-9A-F]{2}:[0-9A-F]{2}:' +


unexpected indentation

houndci-bot · 2018-03-28T19:56:58Z

homeassistant/components/device_tracker/tplink.py

+        self.credentials = ''
+        self.token = ''
+        # I had to rewrite due c50 responds with colon mac instead of dash
+        self.parse_macs_c50 = 


trailing whitespace
SyntaxError: invalid syntax

houndci-bot · 2018-03-28T20:18:39Z

homeassistant/components/device_tracker/tplink.py

+
+        payload = '[LAN_HOST_ENTRY#0,0,0,0,0,0#0,0,0,0,0,0]0,4\r\n' + \
+            'leaseTimeRemaining\r\nMACAddress\r\nhostName\r\nIPAddress\r\n'
+


blank line contains whitespace

houndci-bot · 2018-03-28T20:18:39Z

homeassistant/components/device_tracker/tplink.py

+        self.credentials = base64.b64encode(credentials).decode('utf')
+
+        # Create the authorization cookie.
+        cookie = 'Authorization=Basic {}'.format(self.credentials)


local variable 'cookie' is assigned to but never used

houndci-bot · 2018-03-28T20:18:39Z

homeassistant/components/device_tracker/tplink.py

+    def _get_auth_tokens(self):
+        """Retrieve auth tokens from the router."""
+        _LOGGER.info("Retrieving auth tokens...")
+        url = 'http://{}/'.format(self.host)


local variable 'url' is assigned to but never used

syssi · 2018-04-06T06:08:04Z

homeassistant/components/device_tracker/tplink.py

+        # CHECK DHCP CLIENT LIST
+        url = 'http://{}/cgi?5'.format(self.host)
+        referer = 'http://{}/'.format(self.host)
+        cookie = 'Authorization=Basic {}'.format(self.credentials)


The credentials are always empty.

syssi · 2018-04-06T06:11:03Z

homeassistant/components/device_tracker/tplink.py

+    def __init__(self, config):
+        """Initialize the scanner."""
+        self.credentials = ''
+        self.token = ''


The token is unused.

syssi · 2018-04-06T06:14:33Z

homeassistant/components/device_tracker/tplink.py

+        self.credentials = ''
+        self.token = ''
+        # I had to rewrite due c50 responds with colon mac instead of dash
+        self.parse_macs_c50 = re.compile('[0-9A-F]{2}:[0-9A-F]{2}:' +


This is fine. Please rewrite or remove the comment. You could overwrite self.parse_macs here. A new variable isn't needed to my mind.

syssi · 2018-04-06T20:13:24Z

@melkyfb Before you invest more time: Please checkout this PR #11827. It looks like you should use pytplinkrouter here and the component needs some love at all!

balloob · 2018-05-02T18:41:21Z

Please provide a PR to use pytplinkrouter. We should not add new classes to this file.

Added suport for TP-Link Archer C50 V3 BR Version to device_tracker

52eb889

homeassistant added integration: device_tracker core labels Mar 28, 2018

houndci-bot reviewed Mar 28, 2018

View reviewed changes

updated due houndci-bot changes asked

01f6984

homeassistant added the cla-needed label Mar 28, 2018

houndci-bot reviewed Mar 28, 2018

View reviewed changes

homeassistant added cla-signed and removed cla-needed labels Mar 28, 2018

updated due houndci-bot changes asked

afd4a12

houndci-bot reviewed Mar 28, 2018

View reviewed changes

melkyfb added 2 commits March 28, 2018 17:23

changes asked by houndci-bot

3a0d4e1

travis tox changes

81453e9

fabaff changed the title ~~Added suport for TP-Link Archer C50 V3 BR Version to device_tracker~~ Added support for TP-Link Archer C50 V3 BR Version Mar 29, 2018

syssi reviewed Apr 6, 2018

View reviewed changes

balloob closed this May 2, 2018

home-assistant locked and limited conversation to collaborators Sep 5, 2018


		payload = '[LAN_HOST_ENTRY#0,0,0,0,0,0#0,0,0,0,0,0]0,4\r\n' + \
		'leaseTimeRemaining\r\nMACAddress\r\nhostName\r\nIPAddress\r\n'

Uh oh!

Conversation

MelkyFB-zz commented Mar 28, 2018

Description:

Checklist:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

homeassistant commented Mar 28, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

syssi commented Apr 6, 2018

Uh oh!

balloob commented May 2, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants