Add TP-Link powerline and Archer C7 device trackers#14801
Closed
Onager wants to merge 1 commit intohome-assistant:devfrom
Closed
Add TP-Link powerline and Archer C7 device trackers#14801Onager wants to merge 1 commit intohome-assistant:devfrom
Onager wants to merge 1 commit intohome-assistant:devfrom
Conversation
Contributor
Member
|
I suppose this has been mentioned earlier in other tplink related PRs, but I'd say it's time for someone to step up and create a library from the device specific communication and make this platform use that instead of having this all inside homeassistant's code base... |
Contributor
|
Right, it has been mentioned/decreed before and a basic library actually already exists. So we should start using that. @Onager I hope you are not put down by this, it's just that you picked a module already in bad shape for your first contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add two new TP-Link device trackers
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: