Skip to content

Remove zeroconf from ssdp after deps #111326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 3 commits into from
Feb 27, 2024
Merged

Remove zeroconf from ssdp after deps #111326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6233e1a
Remove zeroconf from ssdp after deps
bdraco Feb 25, 2024
8824659
adjust test
bdraco Feb 25, 2024
29c4b84
Merge branch 'dev' into remove_zeroconf_ssdp_after
bdraco Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion homeassistant/components/ssdp/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"domain": "ssdp",
"name": "Simple Service Discovery Protocol (SSDP)",
"after_dependencies": ["zeroconf"],
"codeowners": [],
"dependencies": ["network"],
"documentation": "https://www.home-assistant.io/integrations/ssdp",
Expand Down
6 changes: 2 additions & 4 deletions tests/test_requirements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,15 +565,13 @@ async def test_discovery_requirements_ssdp(hass: HomeAssistant) -> None:
) as mock_process:
await async_get_integration_with_requirements(hass, "ssdp_comp")

assert len(mock_process.mock_calls) == 5
assert len(mock_process.mock_calls) == 4
assert mock_process.mock_calls[0][1][1] == ssdp.requirements
# Ensure zeroconf is a dep for ssdp
assert {
mock_process.mock_calls[1][1][0],
mock_process.mock_calls[2][1][0],
mock_process.mock_calls[3][1][0],
mock_process.mock_calls[4][1][0],
} == {"http", "network", "recorder", "zeroconf"}
} == {"http", "network", "recorder"}


@pytest.mark.parametrize(
Expand Down