Fix issue #2675 where E_NOTICE is generated on admin order creation page#2676
Closed
erikhansen wants to merge 2 commits intomagento:developfrom
Closed
Conversation
…ation page - When admin order page is loaded with "Shopping Cart Display Settings > Include Tax In Order Total" is set to yes, page will error due to missing "tax" key
Contributor
|
Thank you for the PR! We are currently waiting for the travis builds to work again, which should happen in a few days. Once that is running and the tests are green we can continue to process your contribution. |
…en-admin-order-created-with-specific-tax-settings
Contributor
|
Thanks for submitting the PR. We fixed the issue in internal ticket MAGETWO-46808 and the fix has been merged into mainline. |
erikhansen
deleted the
feature/error-when-admin-order-created-with-specific-tax-settings
branch
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 9, 2018
…amespace-agnostic-2.3-develop [borg] MAGETWO-92468: Make PR testsuite namespace-agnostic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #2675