Skip to content

[Forwardport] ISSUE-11477 - fixed Swagger response for searchCriteria - added zero …#15946

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
gelanivishal:2.3-develop-PR-port-15322
Jun 11, 2018
Merged

[Forwardport] ISSUE-11477 - fixed Swagger response for searchCriteria - added zero …#15946
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
gelanivishal:2.3-develop-PR-port-15322

Conversation

@gelanivishal
Copy link
Copy Markdown
Contributor

Original Pull Request

#15322

Added zero index to array signifier in searchCriteria parameters builder

Description

This fix allows to generate correct response when user want to test method with some search criteria parameters in Swagger.

Fixed Issues (if relevant)

  1. Magento REST API Schema (Swagger) is not compatible with Search Criteria #11477: Magento REST API Schema (Swagger) is not compatible with Search Criteria

Manual testing scenarios

  1. Open Swagger
  2. In method "catalogProductRepositoryV1" fill in "Parameters" tab values for searchCriteria which use "filterGroups" key
  3. Click "Try it out!"
  4. Check if Response Code is 200

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added the Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" label Jun 8, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 11, 2018
@magento-engcom-team magento-engcom-team merged commit d76fe20 into magento:2.3-develop Jun 11, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 11, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @vgelani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants