Conversation
…7771) sysext was previously using the L1Address field from the devnet-env.json, which netchef does not use. We remove this field to prevent future confusion and switch to the correct `Address` field.
…imism#17772) in persistent devnets with longer block times, it can take longer than the previously-configured 60 seconds, leading to timeouts and flakes.
…#17757) * op-acceptance-tests: fix test due to geth breakage geth changed the value of params.HistoryServeWindow and it broke the test. ethereum/go-ethereum#32127 * op-acceptance-tests: avoid failing when we can wait
* ctb: Skip blueprint DG impl verification When the deploy dipuste game v2 feature flag is enabled, we should skip verification of the old v1 implementation blueprints * assert zero-valued blueprint address * fix typo
* Bump 'current' cannon vm to version 8 * Update docker diff check * Always build "next" version of cannon
…le bitmap (ethereum-optimism#17994) Allows things to be combined easily and avoids the risk of features being left disabled because they were later overwritten.
- spammer schedules emit warning logs too often. - DA footprint test does not retry while looking for an L1 origin often enough. The root problem (arbitrary timeouts everywhere) can be addressed later.
* chore: Go cache for several uncached builds * chore: Comment * chore: Fix modules for cache * fix: Don't cache fuzz tests * chore: Restore cache for make-fuzz * chore: Better parallel output * chore: Restore cache namespace * fix: Typo
…ism#18064) * Revert "Always build "next" version of cannon" This reverts commit 71ea701. * Only use 'next' cannon prestate if it differs from the current prestate
…um-optimism#18051) * feat: run dev features thru normal tests * fix: test suite names * fix: skip test for v2 dispute game feature * fix: build go ffi * fix: build source before coverage tests
The caller of cmd.StdoutPipe() must finish reading from the returned io.ReadCloser before calling cmd.Wait(), otherwise not all of the logs will be read. This is a race condition that resulted in occasional test flakes. This commit fixes the buggy test and removes a lot of unnecessary code in the process.
* WIP - Passing metrics env vars through in l2_cl_kona - Added L2MetricsDashboard sysgo lifecycle component * Documenting and wiring up L2MetricsDashboard Also adds some util unit tests * Adding op-reth metrics support Also: - Updates README with more useful metrics info - Fixes error log in l2_cl_kona.go - Changes default docker exec path to `docker` - Makes available port util threadsafe * Updating GetAvailableLocalPort signature * Adding logging context in kona-node, op-reth, l2 metrics dashboard * GetEnvVarOrDefault: os.GetEnv => os.LookupEnv to allow for setting "" * Single env var to enable/disable metrics for all configured components * Encapsulate vars and functions within sysgo package * Inline metrics endpoint parsing from logs * Adding issues to kona and op-reth and referencing in metrics port setting * Making metrics' subprocesses start/stop in parallel * Moving PrometheusMetricsEndpoint into l2_metrics_dashboard.go * Using new L2MetricsRegistrar interface instead of callbacks Also uses stack.IDWithChain instead of service name * Simplifying PrometheusMetricsTarget Still conveys how to interpret the host & port without storing that on the struct * Using logger's key-value format where possible * Handling file close errors when writing metrics configs * Fixing broken test * Making metrics url parsing more resilient * Start/Stop updates - Removing goroutines from Start - Blocking on waitgroup in Stop instead of waitgroup or context done * Removing failure when registering the same endpoint twice * Removing redundant if * Unexporting util functions * Pinning specific versions of prometheus and grafana Overrides are possible via env vars * Updating Subprocess.Stop calls after rebase
was seeing lots of insufficient funds errors on Jovian alphanet
…um-optimism#18050) * Add validation input for cannon-kona prestate * Pass errorPrefix as a parameter to assertValidPermissionlessDisputeGame * Inject gameType into assertValidPermissionlessDisputeGame * Add checks for cannon-kona game type * Cleanup - rename game variables for clarity * Cleanup: guard logic that is only necessary for v1 games * Deploy cannon-kona game for standard validator tests * Update existing test error expectations * Add CannonKona tests * Bump contract versions * Run pre-pr * Preserve current validation methods and structs * Run pre-pr
…mism#18074) * fix(op-batcher): exempt generic da from max input size * Apply suggestion from @sebastianst --------- Co-authored-by: Javed Khan <tuxcanfly@gmail.com> Co-authored-by: Sebastian Stammler <seb@oplabs.co>
…17925) * add Test_ProgramAction_OperatorFeeFixTransition * fix * undo changes to submodule * respond to review
… fix tests (ethereum-optimism#17744) * remove proxyAdmin inputs from opcm and sv, derive it from the sysCfg, fix tests * run semver lock for sv * remove unused imports * adapt go code, fix go tests * fix UpgradeOPChain test * fix addGameType go test * use semverComp to make interface usage checks flexible * fix failing ci * use better naming for old opcm interfaces and related contracts * fix go tests * try fix op-acceptance tests * finally fix op-acceptance tests? * update block number in justfile and not do u16a upgrade on tests * add upgradeSuperchainConfig pkg and add e2e bootstrap test for it upgrade in v5_0_0 pkg * fix failing upgrade go test, add more upgradeOPChain solidity test * rm old validate fn from sv interface * rm unused import * add unexpectedEncoding revert test and improved assertion to upgradOPChainInput * fix semgrep * fix upgradeSuperchainConfig script * make upgrade test fork a specific block * update addGameType to support the new opcm addGameType interface * fix go lint * fixes * fixes * fixes * fix semver and go lint * fix go test * fix go test * fix go test * fixes * fixes for add game type go test * fixes * remove outdated test * pull and fix
…8066) * ctb: Fix OPCM std validator test setup for v2 DG * fix typo
ethereum-optimism#18027) * op-deployer: Fix error handling in add_game_type CLI parsing. Previously it exited with an error message when there was no error. * op-deployer: Add flags for new implementations options Also provides standard values as defaults.
* opcm: Add CANNON_KONA support for opcm.upgrade * fix sepolia upgrade integration test * run cannon-kona upgrade in integration test * remove debugme * fix stdvalidator.test_init * fix outdated opcm bindings * update semver; snapshots * cleanup setNewGameImplV2 * fix semver; fix natspec * fix op-deployer Migrate input encoding * fix nits * fix semantic merge conflict * fix fmt * update semver * only expect cannon-kona reverts if feature flag set
* all: Remove cannon-kona dgv2 feature flags * review comments * move dg impls to stdvalidator impls * fix typo * remove dead assignment * update opcmv2 semver
…ps (ethereum-optimism#18601) * feat(ai-contracts-test): add TOML-based no-changes tracking system - add no-need-changes.toml file for tracking tests with comprehensive coverage - modify ranker to detect stale entries by comparing contract git hashes - output stale_toml_entries array in ranking JSON - inject formatted stale entry list into rendered prompt via placeholder - remove ReinitializableBase.t.sol file from the exclusion file * fix(ai-contracts-test): improve Devin client session handling - add retry loop with exponential backoff for session creation - track blocked state duration and exit after 5-minute timeout - parse nested structured_output for no-changes detection - change status value from finished_no_changes to no_changes_needed * refactor(ai-contracts-test): simplify Slack notification logic - replace prepare_notification.sh with build_notification.sh - add notification for TOML tracking PRs when no changes needed - create build-slack-notification just command wrapping the script - update CircleCI to call new just command * chore(ai-contracts-test): update configuration and documentation - bump VERSION to 1.4.0 for TOML tracking feature - remove ReinitializableBase.t.sol from exclusion list - update runbook with TOML tracking system documentation - document stale entry detection and automatic reintegration * fix(ai-contracts-test): detect no-changes status from structured output - check structured_output for changes_needed field when Devin blocks - add PR URL logging for both "finished" and "no_changes_needed" statuses - wait up to 5 minutes for structured_output to populate after blocked state - prioritize structured_output check before falling back to PR-only detection * chore(ai-contracts-test): add tests to no-changes tracking - add ReinitializableBase.t.sol entry to no-need-changes.toml - add SafeSend.t.sol entry to no-need-changes.toml
…ethereum-optimism#18540) * Add op-rbuilder submodule * Add rollup-boost submodule * Move kona => kona-proofs * Add kona submodule * Update CI to build rust binaries ahead of acceptance test time
…18606) * op-e2e: Enable jovian for proofs precompile tests * op-e2e: Also enable osaka on L1
…8571) * wiring for l2.follow.source * Follow Safe without handling external safe > local unsafe * safe follow * safe follow consider unsafe gap EL Sync * follow finalized * Comments * cleanup * drop unused interface methods * sanity check external finalized * Adjust follow source log level * op-devstack: Follow Source Support * op-acceptance-tests: Follow Source * op-devstack: Follow Source Support * simplify labeling * l1 reorg protection: reset * add reorg tc * typo * follow source: check unsafe * convention * Add unsafe only reorg test * devstack/acceptance test : rename FollowSource to FollowL2 * follow upstream source enabled when derivation disabled, reorg detection * fix unsafe only reorg sync test comments * rm unused interface method * dsl * devstack support for ext sync test + follow l2 * op-acceptance-tests: Follow L2 using Ext + SyncTester * use blockref * fix log msg err * Fix composite interface naming * op-node: Follow Source: EL / CL support * devstack: Allow EL or CL to be follow source * Inject CurrentL1 * logs for injecting CurrentL1 * refactor to less rpc calls * acceptance-tests: Check CurrentL1 is advancing * linter * fix error args * sanity check external values using L1 * op-node: Follow Source CL and drop unsafeOnly * op-acceptance-tests: drop EL follow source / Unsafe Only tests * op-devstack|acceptance-tests: Follow Source CL * op-node: Follow Client: only allow CL source * drop unused args * rm redundant unsafe head reorg logic * rm unused dsl * Do not use functions
* chore: Add SafeRename ioutil utility * fix: Lint
…8583) * feat: have OPCMv2 check upgrade ordering version This PR introduces a check in OPCM that validates that the version difference in the previous OPCM and the current OPCM is acceptable. This PR explicitly disallows skipping OPCM versions which was previously an implicit requirement. * fix: properly set version testing flag * fix: semver lock * fix: move valid instructions allowance * fix: semver lock * fix: better mechanism for checking permitted upgrades * fix: properly run permitted upgrade sequence tests
* chore: bump opcmv2 to v7 * fix: correct version in upgrade sequence * fix: broken tests
* verify opcm v2 * fixes * fixes * some fixes * some fixes * some fixes * fix verifyOPCM v1 tests * fix verifyOPCM v1 tests * fix ci checks * better approach to tests, less diff * improve test coverage * fix typo * fix semver * Update packages/contracts-bedrock/scripts/deploy/VerifyOPCM.s.sol Co-authored-by: 0xOneTony <112496816+0xOneTony@users.noreply.github.com> --------- Co-authored-by: 0xOneTony <112496816+0xOneTony@users.noreply.github.com>
…8637) * ci: Fix contracts test-upgrade test junit output * fix test-upgrade xml output
* proofs: Add provable output roots to super DGs This patch updates the SuperFaultDisputeGame to explicitly prove output roots contained in the super root. This is accomplished by requiring proposers to provide the preimage of the super root when creating a SuperFaultDisputeGame. The Super DG is then extended with a rootClaim(uint256 _l2ChainId) method that returns specific output roots contained in the proposal. This allows withdrawals to be proven using only an output root. * review comments * fix nits; update interfaces * update snapshots * fix panic in non-l2oo proposals
Pull in superchain registry changes and a few other minor changes. No upstream merges.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ClaytonNorthey92
force-pushed
the
clayton/merge-upstream
branch
from
70817fb to
b176413
Compare
ClaytonNorthey92
force-pushed
the
clayton/merge-upstream
branch
from
b176413 to
c5af0b9
Compare
ClaytonNorthey92
requested review from
AL-CT,
jcvernaleo,
joshuasing,
marcopeereboom and
max-sanchez
max-sanchez
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged with upstream commit ethereum-optimism@56a3b91
which is what roughly aligns with what we have in
op-gethlocalnet test passing here https://github.com/hemilabs/heminetwork/actions/runs/21415094873/job/61661548861
there were a few functions that were not in our op-geth fork at the time of writing this, I put them in
toggle.gofor now. we should add them after merging this (I want to do one thing at a time; I can create an issue for those)