Add kona, rollup-boost, op-rbuilder submodules for acceptance testing#18540
Merged
Add kona, rollup-boost, op-rbuilder submodules for acceptance testing#18540
Conversation
b66cc31 to
1e51ee3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #18540 +/- ##
===========================================
- Coverage 75.78% 75.48% -0.30%
===========================================
Files 189 189
Lines 11239 11239
===========================================
- Hits 8517 8484 -33
- Misses 2576 2611 +35
+ Partials 146 144 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
3b1c822 to
c53eeb7
Compare
9d97fdd to
994eab7
Compare
theochap
approved these changes
Dec 8, 2025
Member
theochap
left a comment
There was a problem hiding this comment.
Looks good a few comments. Approving to unblock
sebastianst
reviewed
Dec 9, 2025
37a2541 to
47054e5
Compare
5027b2a to
7f2e6f8
Compare
sebastianst
requested changes
Dec 10, 2025
7f2e6f8 to
a526d1d
Compare
theochap
added a commit
that referenced
this pull request
Dec 11, 2025
sebastianst
reviewed
Dec 11, 2025
a526d1d to
0beeb28
Compare
sebastianst
requested changes
Dec 12, 2025
c10df2d to
b424527
Compare
8edbe1c to
0409b11
Compare
0409b11 to
05321c2
Compare
sebastianst
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace environment variable requirements (
ROLLUP_BOOST_EXEC_PATH,OP_RBUILDER_EXEC_PATH,KONA_NODE_EXEC_PATH,KONA_SUPERVISOR_EXEC_PATH) with automatic binary discovery and optional JIT compilation.Changes
op-devstack/sysgo:
rust_binary.gowith sharedEnsureRustBinary()utility that locates Rust binaries usingrustcandcargo metadatarollup_boost.go,op_rbuilder.go,l2_cl_kona.go,supervisor_kona.goto use the new utilitysystem.goJustfiles:
build-debugtargets tokona/justfile,op-rbuilder/justfile,rollup-boost/Justfilebuild-rust-debugto rootjustfileto build all Rust binariesop-acceptance-tests/justfileto build Rust binaries during local test setupCI (.circleci/config.yml):
rust-binaries-for-sysgojob to pre-build and cache binariesacceptance-testsandscheduled-flake-shakeworkflowsBehavior
just acceptance-testbuilds binaries automatically, or setRUST_JIT_BUILD=1for on-demand compilation during tests