Skip to content

Comments

Add kona, rollup-boost, op-rbuilder submodules for acceptance testing#18540

Merged
teddyknox merged 5 commits intodevelopfrom
teddyknox/local-flashblocks-acceptance-tests
Dec 12, 2025
Merged

Add kona, rollup-boost, op-rbuilder submodules for acceptance testing#18540
teddyknox merged 5 commits intodevelopfrom
teddyknox/local-flashblocks-acceptance-tests

Conversation

@teddyknox
Copy link
Contributor

Replace environment variable requirements (ROLLUP_BOOST_EXEC_PATH, OP_RBUILDER_EXEC_PATH, KONA_NODE_EXEC_PATH, KONA_SUPERVISOR_EXEC_PATH) with automatic binary discovery and optional JIT compilation.

Changes

op-devstack/sysgo:

  • Add rust_binary.go with shared EnsureRustBinary() utility that locates Rust binaries using rustc and cargo metadata
  • Update rollup_boost.go, op_rbuilder.go, l2_cl_kona.go, supervisor_kona.go to use the new utility
  • Remove env var checks from system.go

Justfiles:

  • Add build-debug targets to kona/justfile, op-rbuilder/justfile, rollup-boost/Justfile
  • Add build-rust-debug to root justfile to build all Rust binaries
  • Update op-acceptance-tests/justfile to build Rust binaries during local test setup

CI (.circleci/config.yml):

  • Add rust-binaries-for-sysgo job to pre-build and cache binaries
  • Add job as dependency for acceptance-tests and scheduled-flake-shake workflows

Behavior

  • CI: Binaries are pre-built; missing binaries fail fast with a clear error
  • Local: just acceptance-test builds binaries automatically, or set RUST_JIT_BUILD=1 for on-demand compilation during tests

@teddyknox teddyknox requested review from a team as code owners December 8, 2025 17:48
@teddyknox teddyknox requested a review from serpixel December 8, 2025 17:48
@teddyknox teddyknox force-pushed the teddyknox/local-flashblocks-acceptance-tests branch 2 times, most recently from b66cc31 to 1e51ee3 Compare December 8, 2025 17:54
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.48%. Comparing base (727890b) to head (05321c2).
⚠️ Report is 17 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18540      +/-   ##
===========================================
- Coverage    75.78%   75.48%   -0.30%     
===========================================
  Files          189      189              
  Lines        11239    11239              
===========================================
- Hits          8517     8484      -33     
- Misses        2576     2611      +35     
+ Partials       146      144       -2     
Flag Coverage Δ
cannon-go-tests-64 66.58% <ø> (-0.82%) ⬇️
contracts-bedrock-tests 80.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@teddyknox teddyknox force-pushed the teddyknox/local-flashblocks-acceptance-tests branch 4 times, most recently from 3b1c822 to c53eeb7 Compare December 8, 2025 19:59
@teddyknox teddyknox force-pushed the teddyknox/local-flashblocks-acceptance-tests branch 2 times, most recently from 9d97fdd to 994eab7 Compare December 8, 2025 22:11
Copy link
Member

@theochap theochap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good a few comments. Approving to unblock

@teddyknox teddyknox force-pushed the teddyknox/local-flashblocks-acceptance-tests branch 3 times, most recently from 37a2541 to 47054e5 Compare December 9, 2025 16:49
@teddyknox teddyknox force-pushed the teddyknox/local-flashblocks-acceptance-tests branch 4 times, most recently from 5027b2a to 7f2e6f8 Compare December 9, 2025 20:08
@teddyknox teddyknox requested a review from sebastianst December 9, 2025 21:05
@teddyknox teddyknox force-pushed the teddyknox/local-flashblocks-acceptance-tests branch from 7f2e6f8 to a526d1d Compare December 11, 2025 17:16
theochap added a commit that referenced this pull request Dec 11, 2025
@teddyknox teddyknox force-pushed the teddyknox/local-flashblocks-acceptance-tests branch from a526d1d to 0beeb28 Compare December 11, 2025 21:40
@teddyknox teddyknox force-pushed the teddyknox/local-flashblocks-acceptance-tests branch 4 times, most recently from c10df2d to b424527 Compare December 12, 2025 16:36
@teddyknox teddyknox force-pushed the teddyknox/local-flashblocks-acceptance-tests branch 4 times, most recently from 8edbe1c to 0409b11 Compare December 12, 2025 18:42
@teddyknox teddyknox force-pushed the teddyknox/local-flashblocks-acceptance-tests branch from 0409b11 to 05321c2 Compare December 12, 2025 19:12
@teddyknox teddyknox enabled auto-merge December 12, 2025 19:29
@teddyknox teddyknox added this pull request to the merge queue Dec 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2025
@teddyknox teddyknox added this pull request to the merge queue Dec 12, 2025
Merged via the queue into develop with commit b1ba51b Dec 12, 2025
93 checks passed
@teddyknox teddyknox deleted the teddyknox/local-flashblocks-acceptance-tests branch December 12, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants