Skip to content

Comments

all: Remove cannon-kona dgv2 feature flags#18208

Merged
Inphi merged 8 commits intodevelopfrom
inphi/remove-featureflag
Dec 12, 2025
Merged

all: Remove cannon-kona dgv2 feature flags#18208
Inphi merged 8 commits intodevelopfrom
inphi/remove-featureflag

Conversation

@Inphi
Copy link
Contributor

@Inphi Inphi commented Nov 7, 2025 •
edited
Loading

This PR removes the CANNON_KONA and DEPLOY_V2_DISPUTE_GAMES dev feature flags and makes their behavior the default.

Unresolved Issues

  • Should we maintain deploy scripts for V1 dispute games? These scripts may yet be useful for chains that haven't upgraded. While they will always be available in older op-deployer releases, it's quite convenient for the latest op-deployer to support them.

@codecov
Copy link

codecov bot commented Nov 7, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.89%. Comparing base (adf9b32) to head (8990804).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #18208      +/-   ##
===========================================
- Coverage    75.52%   71.89%   -3.63%     
===========================================
  Files          189      189              
  Lines        11250    11163      -87     
===========================================
- Hits          8496     8026     -470     
- Misses        2610     2993     +383     
  Partials       144      144
Flag Coverage Δ
cannon-go-tests-64 66.58% <ø> (ø)
contracts-bedrock-tests 74.90% <100.00%> (-5.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...es/contracts-bedrock/src/L1/OPContractsManager.sol 89.68% <100.00%> (-4.02%) ⬇️
...ock/src/L1/OPContractsManagerStandardValidator.sol 97.22% <100.00%> (-2.78%) ⬇️
...edrock/src/L1/opcm/OPContractsManagerContainer.sol 100.00% <ø> (ø)
...racts-bedrock/src/L1/opcm/OPContractsManagerV2.sol 95.62% <ø> (ø)
...es/contracts-bedrock/src/libraries/DevFeatures.sol 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ajsutton
ajsutton reviewed Nov 10, 2025
View reviewed changes
@Inphi Inphi linked an issue Nov 13, 2025 that may be closed by this pull request
Kona + Cannon: remove feature toggles #18181
Closed
@opgitgovernance opgitgovernance added the S-stale Status: Will be closed unless there is activity label Nov 26, 2025
@opgitgovernance
Copy link
Contributor

opgitgovernance commented Nov 26, 2025

This pr has been automatically marked as stale and will be closed in 5 days if no updates

@Inphi Inphi removed the S-stale Status: Will be closed unless there is activity label Nov 26, 2025
@Inphi Inphi force-pushed the inphi/remove-featureflag branch from d8731f4 to 13c00a0 Compare November 27, 2025 23:17
@Inphi Inphi force-pushed the inphi/remove-featureflag branch 5 times, most recently from 082b614 to 1abf3f5 Compare December 8, 2025 18:34
@Inphi Inphi force-pushed the inphi/remove-featureflag branch from 1abf3f5 to 1bfdd80 Compare December 8, 2025 18:39
@Inphi Inphi marked this pull request as ready for review December 8, 2025 18:40
@Inphi Inphi requested review from a team as code owners December 8, 2025 18:40
@Inphi Inphi requested review from mbaxter and mds1 December 8, 2025 18:40
stevennevins
stevennevins reviewed Dec 8, 2025
View reviewed changes
@stevennevins stevennevins removed the request for review from mbaxter December 9, 2025 19:01
@stevennevins
Copy link
Contributor

stevennevins commented Dec 10, 2025 •
edited
Loading

@Inphi carrying forward the scripts seems like a nice feature to me

smartcontracts
smartcontracts reviewed Dec 10, 2025
View reviewed changes
smartcontracts
smartcontracts reviewed Dec 10, 2025
View reviewed changes
stevennevins
stevennevins reviewed Dec 10, 2025
View reviewed changes
@Inphi Inphi enabled auto-merge December 12, 2025 00:20
@Inphi Inphi added this pull request to the merge queue Dec 12, 2025
Merged via the queue into develop with commit e7cc171 Dec 12, 2025
94 checks passed
@Inphi Inphi deleted the inphi/remove-featureflag branch December 12, 2025 00:45
Inphi added a commit that referenced this pull request Dec 12, 2025
@Inphi
all: Remove cannon-kona dgv2 feature flags (#18208)
1d0dbe2 
* all: Remove cannon-kona dgv2 feature flags

* review comments

* move dg impls to stdvalidator impls

* fix typo

* remove dead assignment

* update opcmv2 semver
Inphi added a commit that referenced this pull request Dec 12, 2025
@Inphi
all: Remove cannon-kona dgv2 feature flags (#18208)
72326af 
* all: Remove cannon-kona dgv2 feature flags

* review comments

* move dg impls to stdvalidator impls

* fix typo

* remove dead assignment

* update opcmv2 semver
@Inphi Inphi mentioned this pull request Dec 12, 2025
Merged
Inphi added a commit that referenced this pull request Dec 15, 2025
@Inphi
Merge pull request #18588 from ethereum-optimism/inphi/remove-feature…
d6aa14e 
…flag

all: Remove cannon-kona dgv2 feature flags (#18208)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajsutton ajsutton ajsutton left review comments

@smartcontracts smartcontracts smartcontracts approved these changes

@stevennevins stevennevins stevennevins approved these changes

@maurelian maurelian maurelian approved these changes

@mds1 mds1 Awaiting requested review from mds1 mds1 was automatically assigned from ethereum-optimism/op-stack

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Kona + Cannon: remove feature toggles

6 participants

@Inphi @opgitgovernance @stevennevins @ajsutton @smartcontracts @maurelian