This repository was archived by the owner on Feb 22, 2022. It is now read-only.
Correct Uninstall Instructions #1831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
Hi @apeschel. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
needs-ok-to-test
apeschel
force-pushed
the
feature/apeschel/elasticsearch_readme_fix
branch
from
f3cf2b9 to
4f0dddb
Compare
incubator/elasticsearch/README.md
Outdated
Contributor
There was a problem hiding this comment.
Its now called Statefulset
Contributor
|
/assign |
This commit corrects the uninstall instructions in the README for the elasticsearch chart. * Make it clear that the helm delete command is still required * Correct the filter from "type" to "component" * Remove the manual pod deletion, they are automatically removed
apeschel
force-pushed
the
feature/apeschel/elasticsearch_readme_fix
branch
from
4f0dddb to
fb2f00b
Compare
Contributor
Author
|
@dhilipkumars Updated the readme. |
dhilipkumars
added
code reviewed
and removed
needs-ok-to-test
Contributor
|
/lgtm |
lachie83
added a commit
to lachie83/charts
that referenced
this pull request
Aug 29, 2017
* upstream/master: (272 commits) [incubator/redis-cache] helm#1785 namespace defined templates with chart name (helm#1840) [incubator/etcd] helm#1785 namespace defined templates with chart name (helm#1835) Correct Uninstall Instructions (helm#1831) [incubator/patroni] helm#1785 namespace defined templates with chart name (helm#1832) [incubator/kube-registry-proxy] helm#1785 namespace defined templates with chart name (helm#1833) [incubator/docker-registry] helm#1785 namespace defined templates with chart name (helm#1836) [incubator/check-mk] helm#1785 namespace defined templates with chart name (helm#1837) [incubator/tensorflow-inception] helm#1785 namespace defined templates with chart name (helm#1838) [incubator/istio] helm#1785 namespace defined templates with chart name (helm#1839) [stable/etcd-operator] Add cluster.restore, cluster.pod, nodeSelector & update (helm#1200) Spelling and Whitespace Corrections (helm#1853) Added nodeselector and tolerations support for fluent-bit (helm#1846) [stable/traefik] Bump Traefik version to 1.3.6 (helm#1845) [stable/mediawiki] Release 0.4.16 (helm#1830) [stable/kube2iam] Add ability to configure node tolerations (helm#1829) Use latest kube2iam (helm#1825) Upgrade nginx-ingress defaultbackend image (helm#1791) [stable/weave-cloud] sync with upstream (helm#1804) [stable/fluent-bit] release 0.1.6 (Fluent Bit 0.11.17) (helm#1813) [stable/joomla] Release 0.4.15 (helm#1805) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit corrects the uninstall instructions in the README for the
elasticsearch chart. Two changes: