Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Upgrade nginx-ingress defaultbackend image #1791

Merged
mgoodness merged 2 commits into from
Aug 23, 2017
Merged

Upgrade nginx-ingress defaultbackend image #1791

mgoodness merged 2 commits into from
Aug 23, 2017

Conversation

@rubenv
Copy link
Contributor

@rubenv rubenv commented Aug 21, 2017

No description provided.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 21, 2017

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 21, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 21, 2017

Hi @rubenv. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 21, 2017
@rubenv
Copy link
Contributor Author

rubenv commented Aug 21, 2017

CLA signed!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 21, 2017
@mgoodness mgoodness self-assigned this Aug 23, 2017
@mgoodness
Copy link
Contributor

mgoodness commented Aug 23, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 23, 2017
@mgoodness mgoodness self-requested a review August 23, 2017 16:33
mgoodness
mgoodness suggested changes Aug 23, 2017
View reviewed changes
Copy link
Contributor

@mgoodness mgoodness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to bump the chart version (patch should be sufficient)

@rubenv
Copy link
Contributor Author

rubenv commented Aug 23, 2017

@mgoodness Done!

@mgoodness
Copy link
Contributor

mgoodness commented Aug 23, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2017
@mgoodness mgoodness merged commit 9548f62 into helm:master Aug 23, 2017
@rubenv rubenv deleted the patch-1 branch August 23, 2017 17:29
lachie83 added a commit to lachie83/charts that referenced this pull request Aug 29, 2017
@lachie83
Merge remote-tracking branch 'upstream/master'
b7d1ab1 
* upstream/master: (272 commits)
  [incubator/redis-cache] helm#1785 namespace defined templates with chart name (helm#1840)
  [incubator/etcd] helm#1785 namespace defined templates with chart name (helm#1835)
  Correct Uninstall Instructions (helm#1831)
  [incubator/patroni] helm#1785 namespace defined templates with chart name (helm#1832)
  [incubator/kube-registry-proxy] helm#1785 namespace defined templates with chart name (helm#1833)
  [incubator/docker-registry] helm#1785 namespace defined templates with chart name (helm#1836)
  [incubator/check-mk] helm#1785 namespace defined templates with chart name (helm#1837)
  [incubator/tensorflow-inception] helm#1785 namespace defined templates with chart name (helm#1838)
  [incubator/istio] helm#1785 namespace defined templates with chart name (helm#1839)
  [stable/etcd-operator] Add cluster.restore, cluster.pod, nodeSelector & update (helm#1200)
  Spelling and Whitespace Corrections (helm#1853)
  Added nodeselector and tolerations support for fluent-bit (helm#1846)
  [stable/traefik] Bump Traefik version to 1.3.6 (helm#1845)
  [stable/mediawiki] Release 0.4.16 (helm#1830)
  [stable/kube2iam] Add ability to configure node tolerations (helm#1829)
  Use latest kube2iam (helm#1825)
  Upgrade nginx-ingress defaultbackend image (helm#1791)
  [stable/weave-cloud] sync with upstream (helm#1804)
  [stable/fluent-bit] release 0.1.6 (Fluent Bit 0.11.17) (helm#1813)
  [stable/joomla] Release 0.4.15 (helm#1805)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mgoodness mgoodness mgoodness approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mgoodness mgoodness

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rubenv @k8s-ci-robot @mgoodness