This repository was archived by the owner on Feb 22, 2022. It is now read-only.
[stable/weave-cloud] sync with upstream #1804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
errordeveloper
force-pushed
the
master
branch
2 times, most recently
from
d65a310 to
7263b1b
Compare
Contributor
Author
Latest releases: - weaveworks/scope:1.6.2 - prom/prometheus:v1.7.1 - quay.io/weaveworks/fluxd:0.3.0 Minor changes: - mount `/sys/kernel/debug` for access to eBPF - broaden `NoSchedule` tolerations
lachie83
reviewed
Aug 22, 2017
Contributor
lachie83
left a comment
lachie83
left a comment
There was a problem hiding this comment.
One comment otherwise LGTM
| tolerations: | ||
| - effect: NoSchedule | ||
| key: node-role.kubernetes.io/master | ||
| operator: Exists |
Contributor
There was a problem hiding this comment.
Do you still need the key here?
Contributor
Author
There was a problem hiding this comment.
No. Unfortunatelly the docs don't cover this, but it's clear from code comments:
// The matching follows the rules below:
// (1) Empty toleration.effect means to match all taint effects,
// otherwise taint effect must equal to toleration.effect.
// (2) If toleration.operator is 'Exists', it means to match all taint values.
// (3) Empty toleration.key means to match all taint keys.
// If toleration.key is empty, toleration.operator must be 'Exists';
// this combination means to match all taint values and all taint keys.
Contributor
There was a problem hiding this comment.
Wow. Now I'm really confused. I'm going to make it a point to update the docs.
lachie83
added
lgtm
lachie83
added a commit
to lachie83/charts
that referenced
this pull request
Aug 29, 2017
* upstream/master: (272 commits) [incubator/redis-cache] helm#1785 namespace defined templates with chart name (helm#1840) [incubator/etcd] helm#1785 namespace defined templates with chart name (helm#1835) Correct Uninstall Instructions (helm#1831) [incubator/patroni] helm#1785 namespace defined templates with chart name (helm#1832) [incubator/kube-registry-proxy] helm#1785 namespace defined templates with chart name (helm#1833) [incubator/docker-registry] helm#1785 namespace defined templates with chart name (helm#1836) [incubator/check-mk] helm#1785 namespace defined templates with chart name (helm#1837) [incubator/tensorflow-inception] helm#1785 namespace defined templates with chart name (helm#1838) [incubator/istio] helm#1785 namespace defined templates with chart name (helm#1839) [stable/etcd-operator] Add cluster.restore, cluster.pod, nodeSelector & update (helm#1200) Spelling and Whitespace Corrections (helm#1853) Added nodeselector and tolerations support for fluent-bit (helm#1846) [stable/traefik] Bump Traefik version to 1.3.6 (helm#1845) [stable/mediawiki] Release 0.4.16 (helm#1830) [stable/kube2iam] Add ability to configure node tolerations (helm#1829) Use latest kube2iam (helm#1825) Upgrade nginx-ingress defaultbackend image (helm#1791) [stable/weave-cloud] sync with upstream (helm#1804) [stable/fluent-bit] release 0.1.6 (Fluent Bit 0.11.17) (helm#1813) [stable/joomla] Release 0.4.15 (helm#1805) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest releases:
Minor changes:
/sys/kernel/debugfor access to eBPFNoScheduletolerations