-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
This updates the call to _resolveLookupPaths. It returns a string by default since Node.js v8 when called with a third truthy argument. The backwards compatible return value should change soon, so detect what return type is used and handle both cases. Refs: nodejs/node#26983
@hegemonic PTAL |
@hegemonic:Would you mind approving this so as to fix it for Nodejs 12? Thanks! |
Thanks for the pull request, and apologies for the delay in reviewing it. I'll release a new version of this module soon, followed by a new version of JSDoc. (I'm a bit swamped, so I might need a few days to finish all of that.) And you're right, this module is a horrible hack (although you were nice enough not to put it that way). JSDoc ran on Mozilla Rhino before it ran on Node.js, and this module helped bridge the gap between the two. I'm working (very slowly) on a long-term solution, so JSDoc doesn't have to do awful things to the module loader. Unfortunately, that will break lots of stuff, but it's the right thing to do nonetheless. |
FYI, I released an updated version of |
Apparently, 4.x was broken on newer versions of `node`. See this[1] issue for details. Anyways, as of this commit we should build :^) [1] hegemonic/requizzle#4
Apparently, 4.x was broken on newer versions of `node`. See this[1] issue for details. Anyways, as of this commit we should build :^) [1] hegemonic/requizzle#4
Apparently, 4.x was broken on newer versions of `node`. See this[1] issue for details. Anyways, as of this commit we should build :^) [1] hegemonic/requizzle#4
This updates the call to _resolveLookupPaths. It returns a string
by default since Node.js v8 when called with a third truthy argument.
The backwards compatible return value should change soon, so detect
what return type is used and handle both cases.
Refs: nodejs/node#26983
This module uses a lot of Node.js internal functions. Something that recently changed is the wrapper and it is now auto detected if a module manipulates the wrapper or not. If that's the case, a compatibility mode is used instead of the regular file loading mechanism currently in place. It would be great if a different solution could be found than manipulating the wrapper (or the wrapper function).