Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove npm in favour of yarn for local development #704

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Remove npm in favour of yarn for local development #704

merged 1 commit into from
Oct 25, 2019

Conversation

spencercanner
Copy link

  • Removed package-lock.json file
  • Updated jsdoc-to-markdown dependency to the latest version 5.0.1
  • Updated jsdocs dependency to support node v12+ (Future proof hegemonic/requizzle#4)
  • Ran yarn to update the yarn.lock file with the newer dependency versions
  • Update contribution guide, replacing npm with yarn

To 🎩 :

  • In a fresh clone of the library, run the commands in the contribution guide and verify they work

melissaluu
melissaluu approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@melissaluu melissaluu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩'd and looks good!

@rebeccajfriedman
Copy link
Contributor

Thank you for doing this!!

@spencercanner spencercanner merged commit 89037cd into master Oct 25, 2019
@rebeccajfriedman rebeccajfriedman temporarily deployed to production November 15, 2019 14:52 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melissaluu melissaluu melissaluu approved these changes

@rebeccajfriedman rebeccajfriedman rebeccajfriedman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spencercanner @rebeccajfriedman @melissaluu