-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add node12 for ci #3196
chore: add node12 for ci #3196
Conversation
11 有点问题,不合并。 |
Codecov Report
@@ Coverage Diff @@
## master #3196 +/- ##
======================================
Coverage 100% 100%
======================================
Files 34 34
Lines 945 945
======================================
Hits 945 945 Continue to review full report at Codecov.
|
我重新触发了下,如果还不行,就提交一个空的 commit 吧 |
@atian25:如果可以你来合并一下,我没有遇到这种情况……为什么 “continuous-integration/appveyor/branch — AppVeyor build failed” 会都不可以? |
ci 上怎么出这个报错。。 |
看起来是有不兼容 |
eggjs/egg-core#211 应该是有 bug |
doctools 的 win 要 skip |
应该没支持 win,这个不是测 doctools |
首先,此在Win平台测试是为了尽最大可能保证公平性,以及在本地提交时候跑一个完整的测试(包括文档的完整性)的目的,所以不是兼容性测试。 其次,Win本身我在自己的机器上已经测试通过(#3643). 后来发现针对 Nodejs 12 确实存在一个path解析问题( hegemonic/requizzle#5 , hegemonic/requizzle#4 ) |
|
Since today Nodejs 11 is overdue, so change to 12 instead.
update to Nodejs 12
node x64 package not found Appveyor 中 node v12 暂无 stable 版本,等 CI 有该版本后再处理。 |
有Node 12的版本了 😄 |
是不是可以合并了 |
chore: add node12 for ci (#3196)
👍 |
Checklist
npm test
passesAffected core subsystem(s)
Description of change