Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aligned table tutorial #571

Merged
merged 21 commits into from
Apr 15, 2021
Merged

Add aligned table tutorial #571

merged 21 commits into from
Apr 15, 2021

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Apr 14, 2021

  • Add tutorial for AlignedDynamicTable
  • Update make clean command for docs to remove files generated by sphinx-gallery
  • Update docstring of AlignedDynamicTable
  • Add custom thumbnails for all tutorials to ease navigation and make the gallery look nicer

Fix #570
Fix #569
Fix #572
Fix #574

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@oruebel oruebel requested a review from rly April 14, 2021 09:58
@oruebel oruebel requested a review from ajtritt April 14, 2021 11:15
ajtritt
ajtritt previously approved these changes Apr 14, 2021
docs/Makefile Show resolved Hide resolved
@oruebel
Copy link
Contributor Author

oruebel commented Apr 14, 2021

@rly I addressed the issues you raised. Can you please review the changes and approve the PR if everything looks good.

@rly
Copy link
Contributor

rly commented Apr 14, 2021

I made minor suggestions. Otherwise looks good.

rly
rly previously approved these changes Apr 14, 2021
@oruebel
Copy link
Contributor Author

oruebel commented Apr 15, 2021

@rly I added the additional changes you suggested. Can you please re-approve the PR.

@rly
Copy link
Contributor

rly commented Apr 15, 2021

@oruebel Did you push your changes re: tests?

@oruebel
Copy link
Contributor Author

oruebel commented Apr 15, 2021

Sorry, I didn't notice that the push had failed. I just pushed the changes.

@oruebel oruebel merged commit 4982c59 into dev Apr 15, 2021
@oruebel oruebel deleted the add/aligned_table_tutorial branch April 15, 2021 00:22
@oruebel oruebel mentioned this pull request Apr 15, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants