-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aligned table tutorial #571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajtritt
previously approved these changes
Apr 14, 2021
rly
reviewed
Apr 14, 2021
rly
reviewed
Apr 14, 2021
rly
reviewed
Apr 14, 2021
rly
reviewed
Apr 14, 2021
rly
reviewed
Apr 14, 2021
rly
reviewed
Apr 14, 2021
rly
reviewed
Apr 14, 2021
Co-authored-by: Ryan Ly <[email protected]>
Co-authored-by: Ryan Ly <[email protected]>
Co-authored-by: Ryan Ly <[email protected]>
…dev/hdmf into add/aligned_table_tutorial
5 tasks
5 tasks
@rly I addressed the issues you raised. Can you please review the changes and approve the PR if everything looks good. |
rly
reviewed
Apr 14, 2021
rly
reviewed
Apr 14, 2021
I made minor suggestions. Otherwise looks good. |
rly
previously approved these changes
Apr 14, 2021
Co-authored-by: Ryan Ly <[email protected]>
@rly I added the additional changes you suggested. Can you please re-approve the PR. |
…dev/hdmf into add/aligned_table_tutorial
@oruebel Did you push your changes re: tests? |
Sorry, I didn't notice that the push had failed. I just pushed the changes. |
rly
approved these changes
Apr 15, 2021
6 tasks
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make clean
command for docs to remove files generated by sphinx-galleryFix #570
Fix #569
Fix #572
Fix #574
Checklist
flake8
from the source directory.