Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nesting of AlignedDynamicTable #575

Closed
5 tasks done
oruebel opened this issue Apr 14, 2021 · 1 comment
Closed
5 tasks done

Support nesting of AlignedDynamicTable #575

oruebel opened this issue Apr 14, 2021 · 1 comment
Labels
category: enhancement improvements of code or code behavior help wanted: deep dive request for community contributions that will involve many parts of the code base

Comments

@oruebel
Copy link
Contributor

oruebel commented Apr 14, 2021

As identified #571 and #574 while nesting of AlignedDynamicTableis in principle possible---i.e.,we could use an AlignedDynamicTable as a category for another AlignedDynamicTable--- this behavior is currently not supported. In particular the interface functions of AlignedDynamicTable would need to be updated to support this, e.g.:

  • AlignedDynamicTable.__getitem__ does not support more than 3 elements in a selection tuple and would need to be updated to support nested selection behavior.
  • AlignedDynamicTable.to_dataframe will result in error because MulitIndex on the columns would be created with varying numbers of levels for different parts. This would need to be fixed.
  • To prevent the user from nesting AlignedDynamicTables, Add aligned table tutorial #571 added error checks in `AlignedDynamicTable.initandAlignedDynamicTable.add_category`` which would need to be removed if supported.

Checklist

  • Have you ensured the feature or change was not already reported ?
  • Have you included a brief and descriptive title?
  • Have you included a clear description of the problem you are trying to solve?
  • Have you included a minimal code snippet that reproduces the issue you are encountering?
  • Have you checked our Contributing document?
@oruebel oruebel added category: enhancement improvements of code or code behavior help wanted: deep dive request for community contributions that will involve many parts of the code base labels Apr 14, 2021
@oruebel
Copy link
Contributor Author

oruebel commented Apr 14, 2021

There is no explicit need for this feature right now, but could be useful to have. I'm closing this issue for now until we have a real use case. I created this issue mainly for documentation purposes and in case the need should arise in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior help wanted: deep dive request for community contributions that will involve many parts of the code base
Projects
None yet
Development

No branches or pull requests

1 participant