Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow nesting of AlignedDynamicTable #574

Closed
5 tasks done
oruebel opened this issue Apr 14, 2021 · 0 comments · Fixed by #571
Closed
5 tasks done

Do not allow nesting of AlignedDynamicTable #574

oruebel opened this issue Apr 14, 2021 · 0 comments · Fixed by #571
Assignees
@oruebel
Labels
category: bug errors in the code or code behavior

Comments

@oruebel
Copy link
Contributor

oruebel commented Apr 14, 2021

Description

As identified by @rly in #571 while nesting of AlignedDynamicTable is in principle allowed (i.e., use an AlignedDynamicTable as a category for a AlignedDynamicTable), this behavior is currently not supported by AlignedDynamicTable.__getitem__, AlignedDynamicTable.to_dataframe. Implementing this behavior is not trivial. For now we should make sure that errors are raised to prevent users from nesting AlignedDynamicTable and making it clear in the api docs and tutorial that this is not permitted.

Checklist

  • Have you ensured the bug was not already reported ?
  • Have you included a brief and descriptive title?
  • Have you included a clear description of the problem you are trying to solve?
  • Have you included a minimal code snippet that reproduces the issue you are encountering?
  • Have you checked our Contributing document?
@oruebel oruebel added the category: bug errors in the code or code behavior label Apr 14, 2021
@oruebel oruebel self-assigned this Apr 14, 2021
oruebel added a commit that referenced this issue Apr 14, 2021
@oruebel
Fix #574 Do not allow AlignedDynamicTable as category for an AlignedD…
1100c87 
…ynamicTable
This was referenced Apr 14, 2021
Merged
Closed
oruebel added a commit that referenced this issue Apr 15, 2021
@oruebel @rly
Add aligned table tutorial (#571)
4982c59 
* Fix 570 Add tutorial for AlignedDynamicTable
* Fix 569 Remove gallery files on make clean
* Fix #572 Add thumbnails for tutorials
* Fix #574 Do not allow AlignedDynamicTable as category for an AlignedDynamicTable
* Fix docstring formatting of AlignedDynamicTable
* Update CHANGELOG
* Fix test_alignedtable to use assertRaisesWith

Co-authored-by: Ryan Ly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oruebel oruebel

Labels
category: bug errors in the code or code behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add aligned table tutorial hdmf-dev/hdmf
1 participant
@oruebel