provider/azurerm: added local network gateway resource by aznashwan · Pull Request #4342 · hashicorp/terraform

aznashwan · 2015-12-16T15:49:38Z

No description provided.

jen20 · 2015-12-16T15:55:44Z

Hi @aznashwan! This looks good - much easier to add resources now the base work is in!

In order to keep Terraform in a state where it can be released, could you consider adding acceptance tests (in this style) and resource documentation (like this)?

aznashwan · 2015-12-16T23:59:39Z

@jen20 @phinze: not entirely sure how vital this change here is...

👍 good catch!

jen20 · 2015-12-17T14:41:04Z

Hi @aznashwan! Thanks for adding and fixing up the tests. However, running the new local network gateway acceptance tests causes a panic:

$ make testacc TEST=./builtin/providers/azurerm
go generate ./...
TF_ACC=1 go test ./builtin/providers/azurerm -v  -timeout 90m
=== RUN TestProvider
--- PASS: TestProvider (0.00s)
=== RUN TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN TestAccAzureRMLocalNetworkGateway_basic
panic: interface conversion: interface is nil, not []interface {}

goroutine 90 [running]:
github.com/hashicorp/terraform/builtin/providers/azurerm.resourceArmLocalNetworkGatewayCreate(0xc20830b500, 0x5b5f40, 0xc20809c000, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/builtin/providers/azurerm/resource_arm_local_network_gateway.go:81 +0x3c8
github.com/hashicorp/terraform/helper/schema.(*Resource).Apply(0xc20802d6c0, 0xc2080f76b0, 0xc20824b260, 0x5b5f40, 0xc20809c000, 0xf9d01, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/helper/schema/resource.go:145 +0x2c1
github.com/hashicorp/terraform/helper/schema.(*Provider).Apply(0xc20800b620, 0xc20813cc80, 0xc2080f76b0, 0xc20824b260, 0x1, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/helper/schema/provider.go:162 +0x1da
github.com/hashicorp/terraform/terraform.(*EvalApply).Eval(0xc20813ce40, 0xf13a58, 0xc2080d9450, 0x0, 0x0, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/terraform/eval_apply.go:67 +0x62a
github.com/hashicorp/terraform/terraform.EvalRaw(0xf142b8, 0xc20813ce40, 0xf13a58, 0xc2080d9450, 0x0, 0x0, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/terraform/eval.go:53 +0x254
github.com/hashicorp/terraform/terraform.(*EvalSequence).Eval(0xc208254ec0, 0xf13a58, 0xc2080d9450, 0x0, 0x0, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/terraform/eval_sequence.go:10 +0xf9
github.com/hashicorp/terraform/terraform.EvalRaw(0xf13c20, 0xc208254ec0, 0xf13a58, 0xc2080d9450, 0x0, 0x0, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/terraform/eval.go:53 +0x254
github.com/hashicorp/terraform/terraform.(*EvalOpFilter).Eval(0xc208253ad0, 0xf13a58, 0xc2080d9450, 0x0, 0x0, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/terraform/eval_filter_operation.go:37 +0x71
github.com/hashicorp/terraform/terraform.EvalRaw(0xf13c48, 0xc208253ad0, 0xf13a58, 0xc2080d9450, 0x0, 0x0, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/terraform/eval.go:53 +0x254
github.com/hashicorp/terraform/terraform.(*EvalSequence).Eval(0xc208263260, 0xf13a58, 0xc2080d9450, 0x0, 0x0, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/terraform/eval_sequence.go:10 +0xf9
github.com/hashicorp/terraform/terraform.EvalRaw(0xf13c20, 0xc208263260, 0xf13a58, 0xc2080d9450, 0x0, 0x0, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/terraform/eval.go:53 +0x254
github.com/hashicorp/terraform/terraform.Eval(0xf13c20, 0xc208263260, 0xf13a58, 0xc2080d9450, 0x0, 0x0, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/terraform/eval.go:34 +0x79
github.com/hashicorp/terraform/terraform.func·027(0x7ee280, 0xc2082520f0, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/terraform/graph.go:198 +0x906
github.com/hashicorp/terraform/dag.func·006(0x7ee280, 0xc2082520f0, 0xc20810fda0, 0xc20810fe00)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/dag/dag.go:238 +0x106
created by github.com/hashicorp/terraform/dag.(*AcyclicGraph).Walk
    /Users/James/Code/go/src/github.com/hashicorp/terraform/dag/dag.go:247 +0x877

goroutine 1 [chan receive]:
testing.RunTests(0x9e2bf0, 0xc72060, 0x6, 0x6, 0xc76a01)
    /usr/local/Cellar/go14/1.4.2/libexec/src/testing/testing.go:556 +0xad6
testing.(*M).Run(0xc208030460, 0xc7de20)
    /usr/local/Cellar/go14/1.4.2/libexec/src/testing/testing.go:485 +0x6c
main.main()
    github.com/hashicorp/terraform/builtin/providers/azurerm/_test/_testmain.go:62 +0x1d5

goroutine 8 [chan receive]:
github.com/hashicorp/terraform/dag.(*AcyclicGraph).Walk(0xc2080fc9c0, 0xc208106c60, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/dag/dag.go:250 +0x8c4
github.com/hashicorp/terraform/terraform.(*Graph).walk(0xc2080fc9c0, 0xf139c0, 0xc20806fa40, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/terraform/graph.go:237 +0x2c3
github.com/hashicorp/terraform/terraform.(*Graph).Walk(0xc2080fc9c0, 0xf139c0, 0xc20806fa40, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/terraform/graph.go:152 +0x4e
github.com/hashicorp/terraform/terraform.(*Context).walk(0xc2080a9790, 0xc2080fc9c0, 0xc2080fc902, 0x0, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/terraform/context.go:518 +0x1ca
github.com/hashicorp/terraform/terraform.(*Context).Apply(0xc2080a9790, 0x0, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/terraform/context.go:298 +0x1a3
github.com/hashicorp/terraform/helper/resource.testStep(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc20809a270, 0x0, ...)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/helper/resource/testing.go:256 +0xf49
github.com/hashicorp/terraform/helper/resource.Test(0xf126f8, 0xc20805a120, 0xc2080ac9e0, 0xc20800b770, 0x0, 0x9e29a8, 0xc20809a240, 0x1, 0x1)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/helper/resource/testing.go:141 +0x947
github.com/hashicorp/terraform/builtin/providers/azurerm.TestAccAzureRMLocalNetworkGateway_basic(0xc20805a120)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/builtin/providers/azurerm/resource_arm_local_network_gateway_test.go:29 +0x38b
testing.tRunner(0xc20805a120, 0xc72090)
    /usr/local/Cellar/go14/1.4.2/libexec/src/testing/testing.go:447 +0xbf
created by testing.RunTests
    /usr/local/Cellar/go14/1.4.2/libexec/src/testing/testing.go:555 +0xa8b

goroutine 54 [semacquire]:
sync.(*WaitGroup).Wait(0xc208106c80)
    /usr/local/Cellar/go14/1.4.2/libexec/src/sync/waitgroup.go:132 +0x169
github.com/hashicorp/terraform/dag.func·004()
    /Users/James/Code/go/src/github.com/hashicorp/terraform/dag/dag.go:173 +0x52
created by github.com/hashicorp/terraform/dag.(*AcyclicGraph).Walk
    /Users/James/Code/go/src/github.com/hashicorp/terraform/dag/dag.go:174 +0x1b7

goroutine 57 [select]:
github.com/hashicorp/terraform/dag.func·005(0x7b2340, 0xc2080accf0, 0xc2080ad920, 0x1, 0x1, 0xc20802e408, 0x1, 0x1, 0xc2080fcfc0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/dag/dag.go:205 +0x708
created by github.com/hashicorp/terraform/dag.(*AcyclicGraph).Walk
    /Users/James/Code/go/src/github.com/hashicorp/terraform/dag/dag.go:229 +0x730

goroutine 58 [chan receive]:
github.com/hashicorp/terraform/dag.func·006(0x7b2340, 0xc2080accf0, 0xc2080fce40, 0xc2080fcfc0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/dag/dag.go:237 +0xd6
created by github.com/hashicorp/terraform/dag.(*AcyclicGraph).Walk
    /Users/James/Code/go/src/github.com/hashicorp/terraform/dag/dag.go:247 +0x877

goroutine 62 [chan receive]:
github.com/hashicorp/terraform/dag.(*AcyclicGraph).Walk(0xc20810fc20, 0xc2082631a0, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/dag/dag.go:250 +0x8c4
github.com/hashicorp/terraform/terraform.(*Graph).walk(0xc20810fc20, 0xf139c0, 0xc20806fa40, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/terraform/graph.go:237 +0x2c3
github.com/hashicorp/terraform/terraform.func·027(0x8013e0, 0xc2080b2300, 0x0, 0x0)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/terraform/graph.go:217 +0xc22
github.com/hashicorp/terraform/dag.func·006(0x8013e0, 0xc2080b2300, 0xc2080fcf00, 0xc2080fd080)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/dag/dag.go:238 +0x106
created by github.com/hashicorp/terraform/dag.(*AcyclicGraph).Walk
    /Users/James/Code/go/src/github.com/hashicorp/terraform/dag/dag.go:247 +0x877

goroutine 88 [runnable]:
sync.(*WaitGroup).Wait(0xc2082631c0)
    /usr/local/Cellar/go14/1.4.2/libexec/src/sync/waitgroup.go:132 +0x169
github.com/hashicorp/terraform/dag.func·004()
    /Users/James/Code/go/src/github.com/hashicorp/terraform/dag/dag.go:173 +0x52
created by github.com/hashicorp/terraform/dag.(*AcyclicGraph).Walk
    /Users/James/Code/go/src/github.com/hashicorp/terraform/dag/dag.go:174 +0x1b7

goroutine 69 [IO wait]:
net.(*pollDesc).Wait(0xc2080aaf40, 0x72, 0x0, 0x0)
    /usr/local/Cellar/go14/1.4.2/libexec/src/net/fd_poll_runtime.go:84 +0x47
net.(*pollDesc).WaitRead(0xc2080aaf40, 0x0, 0x0)
    /usr/local/Cellar/go14/1.4.2/libexec/src/net/fd_poll_runtime.go:89 +0x43
net.(*netFD).Read(0xc2080aaee0, 0xc20827e800, 0x800, 0x800, 0x0, 0xf11f88, 0xc2082669e8)
    /usr/local/Cellar/go14/1.4.2/libexec/src/net/fd_unix.go:242 +0x40f
net.(*conn).Read(0xc20802e480, 0xc20827e800, 0x800, 0x800, 0x0, 0x0, 0x0)
    /usr/local/Cellar/go14/1.4.2/libexec/src/net/net.go:121 +0xdc
crypto/tls.(*block).readFromUntil(0xc2082a5020, 0xf15c18, 0xc20802e480, 0x5, 0x0, 0x0)
    /usr/local/Cellar/go14/1.4.2/libexec/src/crypto/tls/conn.go:454 +0xe6
crypto/tls.(*Conn).readRecord(0xc208068580, 0x17, 0x0, 0x0)
    /usr/local/Cellar/go14/1.4.2/libexec/src/crypto/tls/conn.go:539 +0x2da
crypto/tls.(*Conn).Read(0xc208068580, 0xc2080a1000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
    /usr/local/Cellar/go14/1.4.2/libexec/src/crypto/tls/conn.go:904 +0x166
net/http.noteEOFReader.Read(0xf1f150, 0xc208068580, 0xc20804c7e8, 0xc2080a1000, 0x1000, 0x1000, 0x6990c0, 0x0, 0x0)
    /usr/local/Cellar/go14/1.4.2/libexec/src/net/http/transport.go:1270 +0x6e
net/http.(*noteEOFReader).Read(0xc2081e9d00, 0xc2080a1000, 0x1000, 0x1000, 0xc208012000, 0x0, 0x0)
    <autogenerated>:125 +0xd4
bufio.(*Reader).fill(0xc2080fdc80)
    /usr/local/Cellar/go14/1.4.2/libexec/src/bufio/bufio.go:97 +0x1ce
bufio.(*Reader).Peek(0xc2080fdc80, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0)
    /usr/local/Cellar/go14/1.4.2/libexec/src/bufio/bufio.go:132 +0xf0
net/http.(*persistConn).readLoop(0xc20804c790)
    /usr/local/Cellar/go14/1.4.2/libexec/src/net/http/transport.go:842 +0xa4
created by net/http.(*Transport).dialConn
    /usr/local/Cellar/go14/1.4.2/libexec/src/net/http/transport.go:660 +0xc9f

goroutine 89 [runnable]:
github.com/hashicorp/terraform/dag.func·005(0x7ee280, 0xc2082520f0, 0xc7f058, 0x0, 0x0, 0xc7f058, 0x0, 0x0, 0xc20810fe00)
    /Users/James/Code/go/src/github.com/hashicorp/terraform/dag/dag.go:228 +0x4c7
created by github.com/hashicorp/terraform/dag.(*AcyclicGraph).Walk
    /Users/James/Code/go/src/github.com/hashicorp/terraform/dag/dag.go:229 +0x730

goroutine 81 [syscall, locked to thread]:
runtime.goexit()
    /usr/local/Cellar/go14/1.4.2/libexec/src/runtime/asm_amd64.s:2232 +0x1

goroutine 70 [select]:
net/http.(*persistConn).writeLoop(0xc20804c790)
    /usr/local/Cellar/go14/1.4.2/libexec/src/net/http/transport.go:945 +0x41d
created by net/http.(*Transport).dialConn
    /usr/local/Cellar/go14/1.4.2/libexec/src/net/http/transport.go:661 +0xcbc
exit status 2
FAIL    github.com/hashicorp/terraform/builtin/providers/azurerm    4.746s
make: *** [testacc] Error 1

jen20 · 2015-12-17T14:42:00Z

This is likely causing the panic mentioned below. Should be address_space I think?

jen20 · 2015-12-17T16:39:22Z

Hi @aznashwan! Thanks for your work on this. I've submitted a pull request back to your branch which makes the acceptance tests pass and matches the patterns established by the exemplar resources. If you could review the changes, verify them for yourself by running the tests, and update here that would be great! The diffs should give a good idea of what is needed for the other open resource PRs as well. Thanks!

This diff represents the changes necessary to make local network gateway tests pass: - Parse the resource ID instead of relying on attributes - Remove unecessary logging (which is handled via the autorest wrapper) - Resource GUID is removed - if this is actually required for anything we may need to find a way to supress it during apply, as we get spurious diffs in plans otherwise. - Various typos fixed.

aznashwan · 2015-12-23T16:53:26Z

@jen20: thanks for the updates; they have been picked in here.

jen20 · 2015-12-31T14:52:02Z

Thanks @aznashwan! Happy New Year!

provider/azure: added local network gateway resource

ghost · 2020-04-29T01:59:14Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

jen20 added enhancement provider/azurerm labels Dec 16, 2015

aznashwan force-pushed the f-azure-localnets branch 2 times, most recently from 79f0581 to 5b1b6a1 Compare December 16, 2015 23:58

aznashwan reviewed Dec 16, 2015
View reviewed changes

aznashwan force-pushed the f-azure-localnets branch from 5b1b6a1 to 42e28f7 Compare December 17, 2015 13:23

jen20 reviewed Dec 17, 2015
View reviewed changes

aznashwan mentioned this pull request Dec 23, 2015

Make local network gateways tests pass aznashwan/terraform#1

Merged

aznashwan and others added 2 commits December 23, 2015 18:49

provider/azure: added local network gateway resource

1eb129a

aznashwan force-pushed the f-azure-localnets branch from de99a23 to 008dc97 Compare December 23, 2015 16:49

aznashwan mentioned this pull request Dec 31, 2015

provider/azurerm: network interfaces and public IP support. #4473

Closed

jen20 added a commit that referenced this pull request Dec 31, 2015

Merge pull request #4342 from aznashwan/f-azure-localnets

9da5dec

provider/azure: added local network gateway resource

jen20 merged commit 9da5dec into hashicorp:master Dec 31, 2015

jen20 changed the title ~~provider/azure: added local network gateway resource~~ provider/azurerm: added local network gateway resource Dec 31, 2015

ghost locked and limited conversation to collaborators Apr 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

provider/azurerm: added local network gateway resource#4342

provider/azurerm: added local network gateway resource#4342
jen20 merged 2 commits into
hashicorp:masterfrom
aznashwan:f-azure-localnets

aznashwan commented Dec 16, 2015

Uh oh!

jen20 commented Dec 16, 2015

Uh oh!

aznashwan Dec 16, 2015

Uh oh!

jen20 Dec 17, 2015

Uh oh!

jen20 commented Dec 17, 2015

Uh oh!

jen20 Dec 17, 2015

Uh oh!

jen20 commented Dec 17, 2015

Uh oh!

aznashwan commented Dec 23, 2015

Uh oh!

jen20 commented Dec 31, 2015

Uh oh!

ghost commented Apr 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

aznashwan commented Dec 16, 2015

Uh oh!

jen20 commented Dec 16, 2015

Uh oh!

aznashwan Dec 16, 2015

Choose a reason for hiding this comment

Uh oh!

jen20 Dec 17, 2015

Choose a reason for hiding this comment

Uh oh!

jen20 commented Dec 17, 2015

Uh oh!

jen20 Dec 17, 2015

Choose a reason for hiding this comment

Uh oh!

jen20 commented Dec 17, 2015

Uh oh!

aznashwan commented Dec 23, 2015

Uh oh!

jen20 commented Dec 31, 2015

Uh oh!

ghost commented Apr 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants