Skip to content

Make local network gateways tests pass#1

Merged
aznashwan merged 1 commit into
aznashwan:f-azure-localnetsfrom
jen20:f-azure-localnets
Dec 23, 2015
Merged

Make local network gateways tests pass#1
aznashwan merged 1 commit into
aznashwan:f-azure-localnetsfrom
jen20:f-azure-localnets

Conversation

@jen20

@jen20 jen20 commented Dec 17, 2015

Copy link
Copy Markdown

This diff represents the changes necessary to make local network gateway tests pass:

  • Parse the resource ID instead of relying on attributes
  • Remove unecessary logging (which is handled via the autorest wrapper)
  • Resource GUID is removed - if this is actually required for anything we may need to find a way to supress it during apply, as we get spurious diffs in plans otherwise.
  • Various typos fixed.

Output from the acceptance tests:

make testacc TEST=./builtin/providers/azurerm TESTARGS="-run AzureRMLocalNetworkGateway"
go generate ./...
TF_ACC=1 go test ./builtin/providers/azurerm -v -run AzureRMLocalNetworkGateway -timeout 90m
=== RUN TestAccAzureRMLocalNetworkGateway_basic
--- PASS: TestAccAzureRMLocalNetworkGateway_basic (56.98s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    56.995s

This diff represents the changes  necessary to make local network
gateway tests pass:

- Parse the resource ID instead of relying on attributes
- Remove unecessary logging (which is handled via the autorest wrapper)
- Resource GUID is removed - if this is actually required for anything
  we may need to find a way to supress it during apply, as we get
  spurious diffs in plans otherwise.
- Various typos fixed.
@aznashwan

Copy link
Copy Markdown
Owner

Hey; my apologies for the delays...
Everything looks like a great catch; merging and updating hashicorp#4342 now.

aznashwan added a commit that referenced this pull request Dec 23, 2015
Make local network gateways tests pass
@aznashwan aznashwan merged commit de99a23 into aznashwan:f-azure-localnets Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants