Skip to content

provider/azurerm: network interfaces and public IP support.#4473

Closed
aznashwan wants to merge 1 commit into
hashicorp:masterfrom
aznashwan:f-arm-ips-ifaces
Closed

provider/azurerm: network interfaces and public IP support.#4473
aznashwan wants to merge 1 commit into
hashicorp:masterfrom
aznashwan:f-arm-ips-ifaces

Conversation

@aznashwan

Copy link
Copy Markdown
Contributor

❗ Not to be merged yet! ❗

Considering the two resource go hand in hand so well together, this PR aims to bring support for both ARM network interfaces and public IPs.

@phinze @jen20: do please glance over the observations I'll leave on the diff; some of them address your proposal from back off load balancer PR (#4343).

PS: for general continuity; this PR was branched from the local network gateways PR (#4342), so please feel free to ignore those files.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phinze: concerning your suggestions to move some of these sub-resources to the top-level: in this particular case, and I'd suspect many more, Creating a network interface without defining at least one such IP configuration leads to a 400.

Also, as I'll point out in the test config; most of these sub-resources have id fields as well and can/must be used in conjunction with other resource/sub-resources.
As such; we may be able to get away with separating some resources; but most will likely turn out impractical to separate.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE for when we add subnets...

@aznashwan

Copy link
Copy Markdown
Contributor Author

See you on the other side boys 😄

@jen20

jen20 commented Jan 19, 2016

Copy link
Copy Markdown
Contributor

Hi all, @stack72 ended up implementing these resources #4565 and #4598, which were subsequently merged, so I'll close this pull request now. Thanks for your work @aznashwan!

@jen20 jen20 closed this Jan 19, 2016
@ghost

ghost commented Apr 28, 2020

Copy link
Copy Markdown

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants