Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated vault_pki_secret_backend resource #1207

Merged
merged 4 commits into from
Oct 29, 2021
Merged

Remove deprecated vault_pki_secret_backend resource #1207

merged 4 commits into from
Oct 29, 2021

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Oct 27, 2021

This PR removes the deprecated vault_pki_secret_backend resource.

It also includes some code cleanup missed in #1181

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1069

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@benashz
Remove vestigial deprecation handling code
ae9c507
@benashz
Remove vault_pki_secret_backend resource
f52d8fb 
- vault_pki_secret_backend was made obsolete by vault_mount
- update docs and related tests
@benashz benashz added this to the 3.0.0 milestone Oct 27, 2021
tomhjp
tomhjp approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@benashz benashz merged commit 035308e into main Oct 29, 2021
@benashz benashz deleted the VAULT-3641/remove-deprecations branch October 29, 2021 16:52
@maxb maxb mentioned this pull request Dec 7, 2021
Closed
benashz added a commit that referenced this pull request Feb 10, 2022
@benashz
Restore formatter, and length for AD secrets engine.
89b606d 
Partially reverts 61935a9 #1207
@benashz benashz mentioned this pull request Feb 10, 2022
Merged
benashz added a commit that referenced this pull request Feb 11, 2022
@benashz
Restore formatter, and length for AD secrets engine. (#1341)
6026031 
Partially reverts 61935a9 #1207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhjp tomhjp tomhjp approved these changes

@vinay-gopalan vinay-gopalan Awaiting requested review from vinay-gopalan

@taoism4504 taoism4504 Awaiting requested review from taoism4504

@tvoran tvoran Awaiting requested review from tvoran

@calvn calvn Awaiting requested review from calvn

Assignees
No one assigned
Labels
documentation size/XL
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

vault_pki_secret_backend has 2-year old deprecation notice
3 participants
@benashz @tvoran @tomhjp