-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated fields #1181
Remove deprecated fields #1181
Conversation
- updates for data_source_kubernetes_auth_backend_role
- updates for resource_approle_auth_backend_role
- updates for resource_aws_auth_backend_role
- updates for resource_azure_auth_backend_role
- updates for resource_cert_auth_backend_role
- updates for resource_consul_secret_backend_role_test
- updates for resource_gcp_auth_backend_role
- updates for resource_github_auth_backend
- updates for resource_github_{team,user}
- updates for resource_jwt_auth_backend_role
- updates for resource_kubernetes_auth_backend_role
- updates for resource_token_auth_backend_role
- updates for resource_generic_secret
- updates for resource_auth_backend
- updates for provider tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me, although I think I'm missing some context on why a couple of the fields are being deleted.
One question on the upgrade experience: if users update deprecated fields to use the new field name, will the terraform plan report any diff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed the upgrade path offline and not much we can do to avoid diff noise. LGTM!
In preparation for the major version bump, all deprecated fields related to < vault-1.2 have been removed.
As this PR is quite large, all related updates to the upgrade guide will be done in a separate PR.
Community Note
Release note for CHANGELOG:
Output from acceptance testing: