Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated fields #1181

Merged
merged 15 commits into from
Oct 4, 2021
Merged

Remove deprecated fields #1181

merged 15 commits into from
Oct 4, 2021

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Sep 30, 2021

In preparation for the major version bump, all deprecated fields related to < vault-1.2 have been removed.

As this PR is quite large, all related updates to the upgrade guide will be done in a separate PR.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

TBD

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
=== RUN   TestDataSourceIdentityEntityName
--- PASS: TestDataSourceIdentityEntityName (2.18s)
=== RUN   TestDataSourceIdentityEntityAlias
--- PASS: TestDataSourceIdentityEntityAlias (2.04s)
=== RUN   TestDataSourceIdentityGroupName
--- PASS: TestDataSourceIdentityGroupName (2.05s)
=== RUN   TestDataSourceIdentityGroupAlias
--- PASS: TestDataSourceIdentityGroupAlias (2.10s)
[...]
--- PASS: TestResourceToken_basic (2.45s)
=== RUN   TestResourceToken_import
--- PASS: TestResourceToken_import (2.78s)
=== RUN   TestResourceToken_full
--- PASS: TestResourceToken_full (2.63s)
=== RUN   TestResourceToken_lookup
--- PASS: TestResourceToken_lookup (2.65s)
=== RUN   TestResourceToken_expire
--- PASS: TestResourceToken_expire (16.30s)
=== RUN   TestResourceToken_renew
--- PASS: TestResourceToken_renew (27.59s)
=== RUN   TestAccTransitCacheConfig
--- PASS: TestAccTransitCacheConfig (7.09s)
=== RUN   TestTransitSecretBackendKey_basic
--- PASS: TestTransitSecretBackendKey_basic (3.86s)
=== RUN   TestTransitSecretBackendKey_rsa4096
--- PASS: TestTransitSecretBackendKey_rsa4096 (6.67s)
=== RUN   TestTransitSecretBackendKey_import
--- PASS: TestTransitSecretBackendKey_import (2.85s)
=== RUN   TestExpandAuthMethodTune
--- PASS: TestExpandAuthMethodTune (0.00s)
=== RUN   TestFlattenAuthMethodTune
--- PASS: TestFlattenAuthMethodTune (0.00s)
=== RUN   TestValidateNoTrailingSlash
--- PASS: TestValidateNoTrailingSlash (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-vault/vault	710.069s

CircleCI received exit code 0
...

- updates for data_source_kubernetes_auth_backend_role
- updates for resource_approle_auth_backend_role
- updates for resource_aws_auth_backend_role
- updates for resource_azure_auth_backend_role
- updates for resource_cert_auth_backend_role
- updates for resource_consul_secret_backend_role_test
- updates for resource_gcp_auth_backend_role
- updates for resource_github_auth_backend
- updates for resource_github_{team,user}
- updates for resource_jwt_auth_backend_role
- updates for resource_kubernetes_auth_backend_role
- updates for resource_token_auth_backend_role
- updates for resource_generic_secret
- updates for resource_auth_backend
@benashz benashz changed the title Vault 3641/remove deprecated fields Remove deprecated fields Sep 30, 2021
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me, although I think I'm missing some context on why a couple of the fields are being deleted.

One question on the upgrade experience: if users update deprecated fields to use the new field name, will the terraform plan report any diff?

vault/resource_gcp_auth_backend_role.go Show resolved Hide resolved
vault/resource_generic_secret.go Show resolved Hide resolved
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed the upgrade path offline and not much we can do to avoid diff noise. LGTM!

@benashz benashz merged commit 063314e into main Oct 4, 2021
@benashz benashz deleted the VAULT-3641/remove-deprecated-fields branch October 5, 2021 12:24
@benashz benashz added this to the 3.0.0 milestone Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants