Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore formatter, and length for AD secrets engine. #1341

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Restore formatter, and length for AD secrets engine. #1341

merged 1 commit into from
Feb 11, 2022

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Feb 10, 2022 •
edited
Loading

Partially reverts 61935a9 #1207

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1253

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@benashz benashz added this to the 3.3.0 milestone Feb 10, 2022
@benashz benashz merged commit 6026031 into main Feb 11, 2022
@benashz benashz deleted the VAULT-4523/revert-ad-deprecations branch February 11, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
documentation size/S
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Revert removal of vault_ad_secret_backend options in #1207
2 participants
@benashz @vinay-gopalan