[Proposal] Default Tags Updates

[johnsonaj]

Description

Default Tags allow practitioners to define tags on the Provider and have them applied to resources, in addition to any tags that are added to the resource itself. During the initial implementation there were known limitations that influenced how default_tags could function and be applied. Since the initial implementation there have been updates to Terraform Plugin SDKv2 and the introduction of Terraform Plugin Framework. These updates will allow changes to default_tags that will address some of the limitations:

With this update Default Tags would be able to:

• Accept Computed values as a tag
• Have to ability to define identical tags that are overwritten on the resource level
• Eliminate perpetual diffs when some but not all tags on a resource match the default_tags

There will be no changes to how default_tags are configured within Terraform. Additionally, the goal is to implement this functionality on all resource that currently support tags, allowing for consistent behavior with all existing configurations.

References

Issues

• Provider produced inconsistent final plan / an invalid new value for .tags_all #19583
• error when default_tags are identical to resource tags #19204
• default_tags always shows an update #18311

Go Docs

• https://pkg.go.dev/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema#ResourceData.GetRawPlan
• https://pkg.go.dev/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema#ResourceData.GetRawState
• https://pkg.go.dev/github.com/hashicorp/[email protected]/resource#ResourceWithModifyPlan

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[johnsonaj]

Resolve in PRs #30793 and #30973. Merged to main in #31392. Will be released in v5.0.0

[github-actions]

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.