Tech debt: Reduce tags boilerplate code - Plugin SDK resources b* (Phase 3c)

[ewbankkit]

Description

Extends the work done in Phase 2 to the remaining resources implemented using Terraform Plugin SDK.

Relations

Relates #30280.
Relates #29747.
Relates #30417.
Relates #30421.
Relates #30430.
Relates #30449.
Relates #30454.
Relates #30461.

Output from Acceptance Testing

% make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=b... ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/b.../... -v -count 1 -parallel 2  -run=_basic$\|_tags$ -timeout 180m
=== RUN   TestAccBackupGlobalSettings_basic
=== PAUSE TestAccBackupGlobalSettings_basic
=== RUN   TestAccBackupPlanDataSource_basic
=== PAUSE TestAccBackupPlanDataSource_basic
=== RUN   TestAccBackupPlan_basic
=== PAUSE TestAccBackupPlan_basic
=== RUN   TestAccBackupRegionSettings_basic
=== PAUSE TestAccBackupRegionSettings_basic
=== RUN   TestAccBackupReportPlanDataSource_basic
=== PAUSE TestAccBackupReportPlanDataSource_basic
=== RUN   TestAccBackupReportPlan_basic
=== PAUSE TestAccBackupReportPlan_basic
=== RUN   TestAccBackupSelectionDataSource_basic
=== PAUSE TestAccBackupSelectionDataSource_basic
=== RUN   TestAccBackupSelection_basic
=== PAUSE TestAccBackupSelection_basic
=== RUN   TestAccBackupVaultDataSource_basic
=== PAUSE TestAccBackupVaultDataSource_basic
=== RUN   TestAccBackupVaultLockConfiguration_basic
=== PAUSE TestAccBackupVaultLockConfiguration_basic
=== RUN   TestAccBackupVaultNotification_basic
=== PAUSE TestAccBackupVaultNotification_basic
=== RUN   TestAccBackupVaultPolicy_basic
=== PAUSE TestAccBackupVaultPolicy_basic
=== RUN   TestAccBackupVault_basic
=== PAUSE TestAccBackupVault_basic
=== RUN   TestAccBackupVault_tags
=== PAUSE TestAccBackupVault_tags
=== CONT  TestAccBackupGlobalSettings_basic
=== CONT  TestAccBackupSelection_basic
=== CONT  TestAccBackupGlobalSettings_basic
    acctest.go:912: this AWS account must be the management account of an AWS Organization
--- SKIP: TestAccBackupGlobalSettings_basic (0.75s)
=== CONT  TestAccBackupReportPlanDataSource_basic
    report_plan_data_source_test.go:21: Step 1/2, expected an error with pattern, no match on: Error running pre-apply refresh: exit status 1
        
        Error: reading Backup Report Plan (tf_acc_test_does_not_exist): couldn't find resource
        
          with data.aws_backup_report_plan.test,
          on terraform_plugin_test.tf line 2, in data "aws_backup_report_plan" "test":
           2: data "aws_backup_report_plan" "test" {
        
--- FAIL: TestAccBackupReportPlanDataSource_basic (4.65s)
=== CONT  TestAccBackupSelectionDataSource_basic
--- PASS: TestAccBackupSelection_basic (40.64s)
=== CONT  TestAccBackupReportPlan_basic
--- PASS: TestAccBackupSelectionDataSource_basic (37.96s)
=== CONT  TestAccBackupPlan_basic
--- PASS: TestAccBackupPlan_basic (43.98s)
=== CONT  TestAccBackupRegionSettings_basic
    region_settings_test.go:20: Step 1/4 error: Check failed: 1 error occurred:
        	* Check 2/17 error: aws_backup_region_settings.test: Attribute 'resource_type_opt_in_preference.%' expected "12", got "15"
        
--- FAIL: TestAccBackupRegionSettings_basic (15.08s)
=== CONT  TestAccBackupPlanDataSource_basic
--- PASS: TestAccBackupReportPlan_basic (73.22s)
=== CONT  TestAccBackupVaultPolicy_basic
--- PASS: TestAccBackupPlanDataSource_basic (30.47s)
=== CONT  TestAccBackupVault_tags
--- PASS: TestAccBackupVaultPolicy_basic (53.68s)
=== CONT  TestAccBackupVault_basic
--- PASS: TestAccBackupVault_basic (33.68s)
=== CONT  TestAccBackupVaultLockConfiguration_basic
--- PASS: TestAccBackupVault_tags (78.65s)
=== CONT  TestAccBackupVaultNotification_basic
--- PASS: TestAccBackupVaultLockConfiguration_basic (39.31s)
=== CONT  TestAccBackupVaultDataSource_basic
--- PASS: TestAccBackupVaultNotification_basic (42.14s)
--- PASS: TestAccBackupVaultDataSource_basic (31.41s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/backup	284.490s
=== RUN   TestAccBatchComputeEnvironmentDataSource_basic
=== PAUSE TestAccBatchComputeEnvironmentDataSource_basic
=== RUN   TestAccBatchComputeEnvironment_basic
=== PAUSE TestAccBatchComputeEnvironment_basic
=== RUN   TestAccBatchComputeEnvironment_tags
=== PAUSE TestAccBatchComputeEnvironment_tags
=== RUN   TestAccBatchJobDefinition_basic
=== PAUSE TestAccBatchJobDefinition_basic
=== RUN   TestAccBatchJobDefinition_tags
=== PAUSE TestAccBatchJobDefinition_tags
=== RUN   TestAccBatchJobQueueDataSource_basic
=== PAUSE TestAccBatchJobQueueDataSource_basic
=== RUN   TestAccBatchJobQueue_basic
=== PAUSE TestAccBatchJobQueue_basic
=== RUN   TestAccBatchJobQueue_tags
=== PAUSE TestAccBatchJobQueue_tags
=== RUN   TestAccBatchSchedulingPolicyDataSource_basic
--- PASS: TestAccBatchSchedulingPolicyDataSource_basic (31.85s)
=== RUN   TestAccBatchSchedulingPolicy_basic
=== PAUSE TestAccBatchSchedulingPolicy_basic
=== CONT  TestAccBatchComputeEnvironmentDataSource_basic
=== CONT  TestAccBatchJobQueueDataSource_basic
--- PASS: TestAccBatchComputeEnvironmentDataSource_basic (61.11s)
=== CONT  TestAccBatchJobQueue_tags
--- PASS: TestAccBatchJobQueueDataSource_basic (123.72s)
=== CONT  TestAccBatchSchedulingPolicy_basic
--- PASS: TestAccBatchSchedulingPolicy_basic (62.29s)
=== CONT  TestAccBatchJobDefinition_basic
--- PASS: TestAccBatchJobDefinition_basic (28.39s)
=== CONT  TestAccBatchJobDefinition_tags
--- PASS: TestAccBatchJobQueue_tags (191.46s)
=== CONT  TestAccBatchJobQueue_basic
--- PASS: TestAccBatchJobDefinition_tags (69.83s)
=== CONT  TestAccBatchComputeEnvironment_tags
--- PASS: TestAccBatchComputeEnvironment_tags (90.98s)
=== CONT  TestAccBatchComputeEnvironment_basic
--- PASS: TestAccBatchJobQueue_basic (132.69s)
--- PASS: TestAccBatchComputeEnvironment_basic (46.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	482.105s
=== RUN   TestAccBudgetsBudgetAction_basic
=== PAUSE TestAccBudgetsBudgetAction_basic
=== RUN   TestAccBudgetsBudget_basic
=== PAUSE TestAccBudgetsBudget_basic
=== CONT  TestAccBudgetsBudgetAction_basic
=== CONT  TestAccBudgetsBudget_basic
--- PASS: TestAccBudgetsBudget_basic (43.77s)
--- PASS: TestAccBudgetsBudgetAction_basic (59.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/budgets	77.405s
FAIL
make: *** [testacc] Error 1

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.