Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Reduce tags boilerplate code - Plugin Framework resources (Phase 3a) #30413

Merged
merged 7 commits into from
Apr 3, 2023
Merged

Tech debt: Reduce tags boilerplate code - Plugin Framework resources (Phase 3a) #30413

merged 7 commits into from
Apr 3, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Apr 3, 2023 •
edited
Loading

Description

Extends the work done in Phase 2 to the remaining resources implemented using Terraform Plugin Framework.

Relations

Relates #30280.
Relates #29747.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccVPCSecurityGroupIngressRule_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCSecurityGroupIngressRule_ -timeout 180m
=== RUN   TestAccVPCSecurityGroupIngressRule_basic
=== PAUSE TestAccVPCSecurityGroupIngressRule_basic
=== RUN   TestAccVPCSecurityGroupIngressRule_disappears
=== PAUSE TestAccVPCSecurityGroupIngressRule_disappears
=== RUN   TestAccVPCSecurityGroupIngressRule_tags
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== PAUSE TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== RUN   TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
=== PAUSE TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
=== RUN   TestAccVPCSecurityGroupIngressRule_ignoreTags
=== PAUSE TestAccVPCSecurityGroupIngressRule_ignoreTags
=== RUN   TestAccVPCSecurityGroupIngressRule_cidrIPv4
=== PAUSE TestAccVPCSecurityGroupIngressRule_cidrIPv4
=== RUN   TestAccVPCSecurityGroupIngressRule_cidrIPv6
=== PAUSE TestAccVPCSecurityGroupIngressRule_cidrIPv6
=== RUN   TestAccVPCSecurityGroupIngressRule_description
=== PAUSE TestAccVPCSecurityGroupIngressRule_description
=== RUN   TestAccVPCSecurityGroupIngressRule_prefixListID
=== PAUSE TestAccVPCSecurityGroupIngressRule_prefixListID
=== RUN   TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
=== PAUSE TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
=== RUN   TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
=== PAUSE TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
=== RUN   TestAccVPCSecurityGroupIngressRule_updateSourceType
=== PAUSE TestAccVPCSecurityGroupIngressRule_updateSourceType
=== CONT  TestAccVPCSecurityGroupIngressRule_basic
=== CONT  TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
=== CONT  TestAccVPCSecurityGroupIngressRule_prefixListID
=== CONT  TestAccVPCSecurityGroupIngressRule_cidrIPv6
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
=== CONT  TestAccVPCSecurityGroupIngressRule_description
=== CONT  TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
=== CONT  TestAccVPCSecurityGroupIngressRule_cidrIPv4
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
=== CONT  TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
=== CONT  TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
=== CONT  TestAccVPCSecurityGroupIngressRule_updateSourceType
=== CONT  TestAccVPCSecurityGroupIngressRule_tags
=== CONT  TestAccVPCSecurityGroupIngressRule_disappears
=== CONT  TestAccVPCSecurityGroupIngressRule_ignoreTags
=== CONT  TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
    acctest.go:772: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC (0.46s)
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag (10.68s)
--- PASS: TestAccVPCSecurityGroupIngressRule_disappears (78.17s)
--- PASS: TestAccVPCSecurityGroupIngressRule_basic (89.35s)
--- PASS: TestAccVPCSecurityGroupIngressRule_updateSourceType (140.27s)
--- PASS: TestAccVPCSecurityGroupIngressRule_cidrIPv6 (140.29s)
--- PASS: TestAccVPCSecurityGroupIngressRule_description (140.44s)
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly (141.68s)
--- PASS: TestAccVPCSecurityGroupIngressRule_cidrIPv4 (142.43s)
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly (143.23s)
--- PASS: TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID (145.22s)
--- PASS: TestAccVPCSecurityGroupIngressRule_ignoreTags (147.01s)
--- PASS: TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags (147.69s)
--- PASS: TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply (149.33s)
--- PASS: TestAccVPCSecurityGroupIngressRule_prefixListID (150.33s)
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag (157.91s)
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly (159.69s)
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag (161.10s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags (162.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	167.842s
% make testacc TESTARGS='-run=TestAccVPCSecurityGroupEgressRule_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCSecurityGroupEgressRule_ -timeout 180m
=== RUN   TestAccVPCSecurityGroupEgressRule_basic
=== PAUSE TestAccVPCSecurityGroupEgressRule_basic
=== RUN   TestAccVPCSecurityGroupEgressRule_disappears
=== PAUSE TestAccVPCSecurityGroupEgressRule_disappears
=== CONT  TestAccVPCSecurityGroupEgressRule_basic
=== CONT  TestAccVPCSecurityGroupEgressRule_disappears
--- PASS: TestAccVPCSecurityGroupEgressRule_disappears (21.03s)
--- PASS: TestAccVPCSecurityGroupEgressRule_basic (23.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	28.630s
% make testacc TESTARGS='-run=TestAccResourceExplorer2_serial/View' PKG=resourceexplorer2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/resourceexplorer2/... -v -count 1 -parallel 20  -run=TestAccResourceExplorer2_serial/View -timeout 180m
=== RUN   TestAccResourceExplorer2_serial
=== PAUSE TestAccResourceExplorer2_serial
=== CONT  TestAccResourceExplorer2_serial
=== RUN   TestAccResourceExplorer2_serial/View
=== RUN   TestAccResourceExplorer2_serial/View/tags
=== RUN   TestAccResourceExplorer2_serial/View/basic
=== RUN   TestAccResourceExplorer2_serial/View/defaultView
=== RUN   TestAccResourceExplorer2_serial/View/disappears
=== RUN   TestAccResourceExplorer2_serial/View/filter
--- PASS: TestAccResourceExplorer2_serial (167.17s)
    --- PASS: TestAccResourceExplorer2_serial/View (167.17s)
        --- PASS: TestAccResourceExplorer2_serial/View/tags (40.33s)
        --- PASS: TestAccResourceExplorer2_serial/View/basic (19.47s)
        --- PASS: TestAccResourceExplorer2_serial/View/defaultView (40.66s)
        --- PASS: TestAccResourceExplorer2_serial/View/disappears (37.55s)
        --- PASS: TestAccResourceExplorer2_serial/View/filter (29.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourceexplorer2	172.495s
% make testacc TESTARGS='-run=TestAccAuditManagerAssessment_\|TestAccAuditManagerControl_\|TestAccAuditManagerFramework_' PKG=auditmanager ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/auditmanager/... -v -count 1 -parallel 3  -run=TestAccAuditManagerAssessment_\|TestAccAuditManagerControl_\|TestAccAuditManagerFramework_ -timeout 180m
=== RUN   TestAccAuditManagerAssessment_basic
=== PAUSE TestAccAuditManagerAssessment_basic
=== RUN   TestAccAuditManagerAssessment_disappears
=== PAUSE TestAccAuditManagerAssessment_disappears
=== RUN   TestAccAuditManagerAssessment_tags
=== PAUSE TestAccAuditManagerAssessment_tags
=== RUN   TestAccAuditManagerAssessment_optional
=== PAUSE TestAccAuditManagerAssessment_optional
=== RUN   TestAccAuditManagerControl_basic
=== PAUSE TestAccAuditManagerControl_basic
=== RUN   TestAccAuditManagerControl_disappears
=== PAUSE TestAccAuditManagerControl_disappears
=== RUN   TestAccAuditManagerControl_tags
=== PAUSE TestAccAuditManagerControl_tags
=== RUN   TestAccAuditManagerControl_optional
=== PAUSE TestAccAuditManagerControl_optional
=== RUN   TestAccAuditManagerControl_optionalSources
=== PAUSE TestAccAuditManagerControl_optionalSources
=== RUN   TestAccAuditManagerFramework_basic
=== PAUSE TestAccAuditManagerFramework_basic
=== RUN   TestAccAuditManagerFramework_disappears
=== PAUSE TestAccAuditManagerFramework_disappears
=== RUN   TestAccAuditManagerFramework_tags
=== PAUSE TestAccAuditManagerFramework_tags
=== RUN   TestAccAuditManagerFramework_optional
=== PAUSE TestAccAuditManagerFramework_optional
=== CONT  TestAccAuditManagerAssessment_basic
=== CONT  TestAccAuditManagerControl_optional
=== CONT  TestAccAuditManagerFramework_disappears
--- PASS: TestAccAuditManagerFramework_disappears (17.30s)
=== CONT  TestAccAuditManagerControl_basic
--- PASS: TestAccAuditManagerAssessment_basic (29.68s)
=== CONT  TestAccAuditManagerControl_tags
--- PASS: TestAccAuditManagerControl_optional (30.92s)
=== CONT  TestAccAuditManagerControl_disappears
--- PASS: TestAccAuditManagerControl_basic (17.51s)
=== CONT  TestAccAuditManagerAssessment_tags
--- PASS: TestAccAuditManagerControl_disappears (12.69s)
=== CONT  TestAccAuditManagerAssessment_optional
--- PASS: TestAccAuditManagerControl_tags (39.67s)
=== CONT  TestAccAuditManagerFramework_optional
--- PASS: TestAccAuditManagerAssessment_optional (47.15s)
=== CONT  TestAccAuditManagerFramework_tags
--- PASS: TestAccAuditManagerAssessment_tags (56.91s)
=== CONT  TestAccAuditManagerAssessment_disappears
--- PASS: TestAccAuditManagerFramework_optional (30.36s)
=== CONT  TestAccAuditManagerControl_optionalSources
--- PASS: TestAccAuditManagerAssessment_disappears (28.19s)
=== CONT  TestAccAuditManagerFramework_basic
--- PASS: TestAccAuditManagerControl_optionalSources (27.94s)
--- PASS: TestAccAuditManagerFramework_tags (42.03s)
--- PASS: TestAccAuditManagerFramework_basic (17.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/auditmanager	145.651s

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added generators Relates to code generators. service/auditmanager Issues and PRs that pertain to the auditmanager service. service/resourceexplorer2 Issues and PRs that pertain to the resourceexplorer2 service. service/vpc Issues and PRs that pertain to the vpc service. size/L Managed by automation to categorize the size of a PR. labels Apr 3, 2023
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Apr 3, 2023
@ewbankkit ewbankkit changed the title Tech debt: Reduce tags boilerplate code - Plugin Framework resources Tech debt: Reduce tags boilerplate code - Plugin Framework resources (Phase 3a) Apr 3, 2023
@ewbankkit ewbankkit merged commit 2144826 into main Apr 3, 2023
@ewbankkit ewbankkit deleted the f-transparent-tagging-framework-resources branch April 3, 2023 16:07
@github-actions github-actions bot added this to the v4.62.0 milestone Apr 3, 2023
github-actions bot pushed a commit that referenced this pull request Apr 3, 2023
Update CHANGELOG.md for #30413
6a8270b
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
generators Relates to code generators. service/auditmanager Issues and PRs that pertain to the auditmanager service. service/resourceexplorer2 Issues and PRs that pertain to the resourceexplorer2 service. service/vpc Issues and PRs that pertain to the vpc service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.62.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ewbankkit