Tech debt: Default resource tag list and update generated functions are package private: listTags and updateTags

[ewbankkit]

Description

Change the default resource tag list and update generated functions to package private: listTags and updateTags.
GetTagsIn -> getTagsIn and SetTagsOut -> setTagsOut.

Relations

Relates #29747.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccLogs.*_tags$$' PKG=logs ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/logs/... -v -count 1 -parallel 3  -run=TestAccLogs.*_tags$ -timeout 180m
=== RUN   TestAccLogsDestination_tags
=== PAUSE TestAccLogsDestination_tags
=== RUN   TestAccLogsGroup_tags
=== PAUSE TestAccLogsGroup_tags
=== CONT  TestAccLogsDestination_tags
=== CONT  TestAccLogsGroup_tags
--- PASS: TestAccLogsGroup_tags (51.70s)
--- PASS: TestAccLogsDestination_tags (96.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	101.438s

% make testacc TESTARGS='-short -run=TestAccVPC.*_tags$$\|TestAccVPC_DefaultTags\|TestAccVPC_DynamicResourceTags\|TestAccVPC_ignoreTags' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -short -run=TestAccVPC.*_tags$\|TestAccVPC_DefaultTags\|TestAccVPC_DynamicResourceTags\|TestAccVPC_ignoreTags -timeout 180m
=== RUN   TestAccVPCDefaultNetworkACL_tags
=== PAUSE TestAccVPCDefaultNetworkACL_tags
=== RUN   TestAccVPCDefaultRouteTable_tags
=== PAUSE TestAccVPCDefaultRouteTable_tags
=== RUN   TestAccVPCDHCPOptions_tags
=== PAUSE TestAccVPCDHCPOptions_tags
=== RUN   TestAccVPCEgressOnlyInternetGateway_tags
=== PAUSE TestAccVPCEgressOnlyInternetGateway_tags
=== RUN   TestAccVPCEndpointServiceAllowedPrincipal_tags
=== PAUSE TestAccVPCEndpointServiceAllowedPrincipal_tags
=== RUN   TestAccVPCEndpointServiceDataSource_CustomFilter_tags
=== PAUSE TestAccVPCEndpointServiceDataSource_CustomFilter_tags
=== RUN   TestAccVPCEndpointService_tags
=== PAUSE TestAccVPCEndpointService_tags
=== RUN   TestAccVPCEndpoint_tags
=== PAUSE TestAccVPCEndpoint_tags
=== RUN   TestAccVPCFlowLog_tags
=== PAUSE TestAccVPCFlowLog_tags
=== RUN   TestAccVPCManagedPrefixList_tags
=== PAUSE TestAccVPCManagedPrefixList_tags
=== RUN   TestAccVPCManagedPrefixListsDataSource_tags
=== PAUSE TestAccVPCManagedPrefixListsDataSource_tags
=== RUN   TestAccVPCNATGateway_tags
=== PAUSE TestAccVPCNATGateway_tags
=== RUN   TestAccVPCNetworkACL_tags
=== PAUSE TestAccVPCNetworkACL_tags
=== RUN   TestAccVPCNetworkACLsDataSource_tags
=== PAUSE TestAccVPCNetworkACLsDataSource_tags
=== RUN   TestAccVPCNetworkInsightsAnalysis_tags
=== PAUSE TestAccVPCNetworkInsightsAnalysis_tags
=== RUN   TestAccVPCNetworkInsightsPath_tags
=== PAUSE TestAccVPCNetworkInsightsPath_tags
=== RUN   TestAccVPCNetworkInterface_tags
=== PAUSE TestAccVPCNetworkInterface_tags
=== RUN   TestAccVPCNetworkInterfacesDataSource_tags
=== PAUSE TestAccVPCNetworkInterfacesDataSource_tags
=== RUN   TestAccVPCPeeringConnection_tags
=== PAUSE TestAccVPCPeeringConnection_tags
=== RUN   TestAccVPCRouteTable_tags
=== PAUSE TestAccVPCRouteTable_tags
=== RUN   TestAccVPCSecurityGroupIngressRule_tags
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags
=== RUN   TestAccVPCSecurityGroupRulesDataSource_tags
=== PAUSE TestAccVPCSecurityGroupRulesDataSource_tags
=== RUN   TestAccVPCSecurityGroup_tags
=== PAUSE TestAccVPCSecurityGroup_tags
=== RUN   TestAccVPCSubnet_tags
=== PAUSE TestAccVPCSubnet_tags
=== RUN   TestAccVPC_tags
=== PAUSE TestAccVPC_tags
=== RUN   TestAccVPC_DefaultTags_zeroValue
=== PAUSE TestAccVPC_DefaultTags_zeroValue
=== RUN   TestAccVPC_DefaultTags_providerOnlyTestAccVPC_DefaultTags_providerOnly
=== PAUSE TestAccVPC_DefaultTags_providerOnlyTestAccVPC_DefaultTags_providerOnly
=== RUN   TestAccVPC_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPC_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPC_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPC_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_moveDuplicateTags
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_moveDuplicateTags
=== RUN   TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== RUN   TestAccVPC_DynamicResourceTags_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTags_ignoreChanges
=== RUN   TestAccVPC_ignoreTags
=== PAUSE TestAccVPC_ignoreTags
=== RUN   TestAccVPCTrafficMirrorFilter_tags
=== PAUSE TestAccVPCTrafficMirrorFilter_tags
=== RUN   TestAccVPCTrafficMirrorSession_tags
=== PAUSE TestAccVPCTrafficMirrorSession_tags
=== RUN   TestAccVPCTrafficMirrorTarget_tags
=== PAUSE TestAccVPCTrafficMirrorTarget_tags
=== RUN   TestAccVPCsDataSource_tags
=== PAUSE TestAccVPCsDataSource_tags
=== CONT  TestAccVPCDefaultNetworkACL_tags
=== CONT  TestAccVPCSecurityGroupIngressRule_tags
=== CONT  TestAccVPCManagedPrefixListsDataSource_tags
--- PASS: TestAccVPCManagedPrefixListsDataSource_tags (30.69s)
=== CONT  TestAccVPCRouteTable_tags
--- PASS: TestAccVPCDefaultNetworkACL_tags (69.63s)
=== CONT  TestAccVPCPeeringConnection_tags
--- PASS: TestAccVPCSecurityGroupIngressRule_tags (72.96s)
=== CONT  TestAccVPCNetworkInterfacesDataSource_tags
--- PASS: TestAccVPCNetworkInterfacesDataSource_tags (27.67s)
=== CONT  TestAccVPCNetworkInterface_tags
--- PASS: TestAccVPCRouteTable_tags (71.19s)
=== CONT  TestAccVPCNetworkInsightsPath_tags
--- PASS: TestAccVPCPeeringConnection_tags (67.41s)
=== CONT  TestAccVPCNetworkInsightsAnalysis_tags
--- PASS: TestAccVPCNetworkInsightsPath_tags (73.57s)
=== CONT  TestAccVPCNetworkACLsDataSource_tags
--- PASS: TestAccVPCNetworkInterface_tags (84.40s)
=== CONT  TestAccVPCNetworkACL_tags
--- PASS: TestAccVPCNetworkACLsDataSource_tags (27.11s)
=== CONT  TestAccVPCNATGateway_tags
--- PASS: TestAccVPCNetworkInsightsAnalysis_tags (104.08s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccVPCNetworkACL_tags (64.62s)
=== CONT  TestAccVPCsDataSource_tags
--- PASS: TestAccVPCsDataSource_tags (22.87s)
=== CONT  TestAccVPCTrafficMirrorTarget_tags
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_overlappingTag (54.75s)
=== CONT  TestAccVPCTrafficMirrorSession_tags
--- PASS: TestAccVPCNATGateway_tags (229.75s)
=== CONT  TestAccVPCEndpointServiceDataSource_CustomFilter_tags
--- PASS: TestAccVPCTrafficMirrorTarget_tags (280.81s)
=== CONT  TestAccVPCManagedPrefixList_tags
--- PASS: TestAccVPCTrafficMirrorSession_tags (318.69s)
=== CONT  TestAccVPCFlowLog_tags
--- PASS: TestAccVPCManagedPrefixList_tags (62.77s)
=== CONT  TestAccVPCEndpoint_tags
--- PASS: TestAccVPCEndpointServiceDataSource_CustomFilter_tags (236.06s)
=== CONT  TestAccVPCEndpointService_tags
--- PASS: TestAccVPCFlowLog_tags (67.44s)
=== CONT  TestAccVPCTrafficMirrorFilter_tags
--- PASS: TestAccVPCEndpoint_tags (75.91s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_moveDuplicateTags
--- PASS: TestAccVPCTrafficMirrorFilter_tags (54.69s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_moveDuplicateTags (52.88s)
=== CONT  TestAccVPC_ignoreTags
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_duplicateTag (19.21s)
=== CONT  TestAccVPC_DynamicResourceTags_ignoreChanges
--- PASS: TestAccVPC_ignoreTags (45.90s)
=== CONT  TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
--- PASS: TestAccVPC_DynamicResourceTags_ignoreChanges (41.17s)
=== CONT  TestAccVPC_DefaultTags_zeroValue
--- PASS: TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges (41.11s)
=== CONT  TestAccVPCEgressOnlyInternetGateway_tags
--- PASS: TestAccVPC_DefaultTags_zeroValue (50.45s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccVPCEgressOnlyInternetGateway_tags (64.89s)
=== CONT  TestAccVPC_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag (58.49s)
=== CONT  TestAccVPC_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPC_DefaultTags_updateToResourceOnly (41.20s)
=== CONT  TestAccVPCEndpointServiceAllowedPrincipal_tags
--- PASS: TestAccVPC_DefaultTags_updateToProviderOnly (42.52s)
=== CONT  TestAccVPCSubnet_tags
--- PASS: TestAccVPCEndpointService_tags (299.81s)
=== CONT  TestAccVPC_tags
--- PASS: TestAccVPCSubnet_tags (60.49s)
=== CONT  TestAccVPCSecurityGroup_tags
--- PASS: TestAccVPC_tags (60.59s)
=== CONT  TestAccVPC_DefaultTags_providerOnlyTestAccVPC_DefaultTags_providerOnly
--- PASS: TestAccVPCSecurityGroup_tags (60.96s)
=== CONT  TestAccVPCSecurityGroupRulesDataSource_tags
--- PASS: TestAccVPC_DefaultTags_providerOnlyTestAccVPC_DefaultTags_providerOnly (51.77s)
=== CONT  TestAccVPCDefaultRouteTable_tags
--- PASS: TestAccVPCSecurityGroupRulesDataSource_tags (27.77s)
=== CONT  TestAccVPCDHCPOptions_tags
--- PASS: TestAccVPCDefaultRouteTable_tags (54.43s)
--- PASS: TestAccVPCDHCPOptions_tags (51.34s)
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_tags (240.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1184.357s

% make testacc TESTARGS='-run=TestAccInspectorAssessmentTemplate_tags' PKG=inspector
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/inspector/... -v -count 1 -parallel 20  -run=TestAccInspectorAssessmentTemplate_tags -timeout 180m
=== RUN   TestAccInspectorAssessmentTemplate_tags
=== PAUSE TestAccInspectorAssessmentTemplate_tags
=== CONT  TestAccInspectorAssessmentTemplate_tags
--- PASS: TestAccInspectorAssessmentTemplate_tags (77.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/inspector	83.709s

[github-actions]

This functionality has been released in v5.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.