Skip to content

feat(showcase): add typescript tooling#2109

Merged
aklkv merged 8 commits intomainfrom
feat/showcase-ts-tooling
May 22, 2024
Merged

feat(showcase): add typescript tooling#2109
aklkv merged 8 commits intomainfrom
feat/showcase-ts-tooling

Conversation

@aklkv
Copy link
Copy Markdown
Collaborator

@aklkv aklkv commented May 16, 2024

📌 Summary

  • add typescript tooling
  • update app blueprint
  • fix in what order GHA runs build/lint/test for showcase as we need components and flight-icons to be built

🛠️ Detailed description

📸 Screenshots

🔗 External links

Jira ticket: HDS-XXX
Figma file: [if it applies]


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@aklkv aklkv requested review from alex-ju, didoo and natmegs May 16, 2024 21:01
@aklkv aklkv self-assigned this May 16, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview May 22, 2024 10:35am
hds-website ✅ Ready (Inspect) Visit Preview May 22, 2024 10:35am

@aklkv aklkv force-pushed the feat/showcase-ts-tooling branch from 0dd8855 to 6578861 Compare May 16, 2024 21:05
@aklkv aklkv force-pushed the feat/showcase-ts-tooling branch from 6578861 to 9c0129b Compare May 18, 2024 02:58
@aklkv aklkv force-pushed the feat/showcase-ts-tooling branch from c712c3f to 9a6069c Compare May 20, 2024 21:57
@aklkv aklkv force-pushed the feat/showcase-ts-tooling branch from 171fe40 to 9a6069c Compare May 20, 2024 22:12
Copy link
Copy Markdown
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aklkv I've left a few comments (one of them, related to the showcase/.prettierrc.js file, makes me think it may be accidental?) but please wait for more TS-knowledgeable people like @alex-ju @natmegs to approve before merging ;)

Comment thread showcase/.editorconfig
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will the introduction of this file impact the existing files (eg. re-writing them, causing a lot of diffs in future PRs?)
should/could this file be added in a sepate PR? or would it impact this PR?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not seen any changes in formatting on my end so I do believe this is a safe change and it will not introduce any charn

Comment thread showcase/.prettierrc.js
Comment thread showcase/blueprints/hds-component-test/index.js
Comment thread showcase/.ember-cli
@alex-ju alex-ju force-pushed the feat/showcase-ts-tooling branch from 42e54cd to a992df6 Compare May 22, 2024 10:31
@alex-ju
Copy link
Copy Markdown
Member

alex-ju commented May 22, 2024

Rebased and regenerated yarn.lock to resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants