Skip to content

Turn on typechecking for text component template in showcase#2107

Closed
natmegs wants to merge 4 commits intomainfrom
showcase
Closed

Turn on typechecking for text component template in showcase#2107
natmegs wants to merge 4 commits intomainfrom
showcase

Conversation

@natmegs
Copy link
Copy Markdown
Contributor

@natmegs natmegs commented May 16, 2024

📌 Summary

Example of how we can use showcase to check types as a consumer for HDS components. This PR opts into template typechecking for the Text component, and similar opt in could be done for showcase templates displaying any typed HDS components.

2 issues preventing this from being merged:

  • Currently there are type failures in the text template since the type of this.model is void, even though route and controller are typed. I must be missing something as these docs indicate the type should be inferred based on route + controller
  • Using glint-expect-error to get around the above results in CLI output saying the expect error is unnecessary, but removing it results in a legit type error

🛠️ Detailed description

📸 Screenshots

🔗 External links

Jira ticket: HDS-XXX
Figma file: [if it applies]


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview May 16, 2024 6:34pm
hds-website ✅ Ready (Inspect) Visit Preview May 16, 2024 6:34pm

@didoo
Copy link
Copy Markdown
Contributor

didoo commented May 22, 2024

@natmegs now that @aklkv PR #2109 has been merged, I think this draft PR can be closed right? (they do the same thing if I'm not wrong).

@didoo
Copy link
Copy Markdown
Contributor

didoo commented Jun 12, 2024

I'm closing this PR.

@didoo didoo closed this Jun 12, 2024
@Dhaulagiri Dhaulagiri deleted the showcase branch August 21, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants