Skip to content

Upgrade @glint/* to 1.5.0#2592

Closed
alex-ju wants to merge 2 commits intomainfrom
alex-ju/upgrade-glint-environment-ember-loose
Closed

Upgrade @glint/* to 1.5.0#2592
alex-ju wants to merge 2 commits intomainfrom
alex-ju/upgrade-glint-environment-ember-loose

Conversation

@alex-ju
Copy link
Copy Markdown
Member

@alex-ju alex-ju commented Dec 9, 2024

📌 Summary

  • Upgrade @glint/environment-ember-loose to 1.5.0 in devDependencies across the monorepo; we used to rely on a patch (commit hash) introduced in feat(showcase): add typescript tooling #2109, but there's no need to use it anymore as it's now part of 1.5.0. It also clears the warnings in yarn.
  • Upgrade @glint/core and @glint/template to keep in sync with @glint/environment-ember-loose

📸 Screenshots

Before

Screenshot 2024-12-09 at 21 43 48

After

Screenshot 2024-12-09 at 21 44 50

💬 Please consider using conventional comments when reviewing this PR.

@alex-ju alex-ju requested a review from a team as a code owner December 9, 2024 21:49
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Dec 9, 2024 10:09pm
hds-website ✅ Ready (Inspect) Visit Preview Dec 9, 2024 10:09pm

@alex-ju
Copy link
Copy Markdown
Member Author

alex-ju commented Dec 9, 2024

This PR unveils ~1589 lint errors in showcase; likely related to https://hashicorp.atlassian.net/browse/HDS-4090.
Will mark it as draft for now.

@alex-ju alex-ju marked this pull request as draft December 9, 2024 22:00
Bring them in line with `@glint/environment-ember-loose`
@alex-ju alex-ju changed the title Upgrade @glint/environment-ember-loose to 1.5.0 Upgrade @glint/* to 1.5.0 Dec 9, 2024
@aklkv
Copy link
Copy Markdown
Collaborator

aklkv commented Dec 10, 2024

@alex-ju I am not sure if my patch was released as part of v1.5 here is ref where the code I have removed in my patch is still in place, since you have removed it it might be the reason for so many lint errors. If you want I can help to reapply this patch, or we just skip this upgrade all together for now.

@alex-ju
Copy link
Copy Markdown
Member Author

alex-ju commented Dec 10, 2024

@alex-ju I am not sure if my patch was released as part of v1.5 here is ref where the code I have removed in my patch is still in place, since you have removed it it might be the reason for so many lint errors. If you want I can help to reapply this patch, or we just skip this upgrade all together for now.

right, I was under the impression that we used the patch for an upcoming feature. thanks for flagging this! If I understand the patch correctly, we'd need to use pod-style templates to be able to move from the patch to v1.5? or is it more than just that?

@aklkv
Copy link
Copy Markdown
Collaborator

aklkv commented Dec 12, 2024

unfortunately my patch is the correct way that the glint should work, but currently it accounts for very old behaviour, going with pods structure is a step backwards and it's pretty big undertaking as well as it's has been already deprecated may not work anymore. My suggestion if there anything valuable that you need in v1.5 we can upgrade and reapply the patch otherwise leave it as is till new version with my patch is released

@alex-ju alex-ju closed this Dec 12, 2024
@alex-ju alex-ju deleted the alex-ju/upgrade-glint-environment-ember-loose branch December 12, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants