New docs website / Fix card image fix #2 #1155
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
force-pushed
the
new-docs-website/fix-twitter-part2
branch
from
34c0f36 to
19a8bdc
Compare
Co-authored-by: Melanie Sumner <[email protected]>
|
Seems (in theory) to have worked |
| {{#if this.model.imgSrc}} | ||
| <meta property="og:image" content={{this.model.imgSrc}} /> | ||
| {{/if}} | ||
| <meta property="og:image" content="https://helios.hashicorp.design/assets/logos/share-card.jpg" /> |
There was a problem hiding this comment.
A side effect of this change is that we are no longer using the logic defined here to update the image where we have a more specific one defined for things like components or foundations
There was a problem hiding this comment.
Opened #1158 to take into account also this logic.
There was a problem hiding this comment.
@Dhaulagiri on a side note: that's why I didn't like the idea of having the config data in the environment.js file (even it's an Ember pattern). Because now things/logic/definitions are scattered around in multiple places, and one needs to know it, and know where, otherwise some pieces are lost (like in this case).
4 participants
📌 Summary
Since the previous fix #1032 didn't work (the image is not fingerprinted) let's try to use a static value instead of a config value.
👀 Reviewer's checklist:
💬 Please consider using conventional comments when reviewing this PR.