Skip to content

New docs website / Fix card image fix #2 #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2023
Merged

New docs website / Fix card image fix #2 #1155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cacf52f
used static values instead of `imgSrc`
didoo Jan 30, 2023
19a8bdc
need to disable linter on specific line or it will complain
didoo Jan 30, 2023
a35b774
Update website/config/environment.js
didoo Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions website/app/templates/head.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,16 @@ We've made some small customizations to simplify this compared to the default te
<meta property="og:description" content={{this.model.description}} />
{{/if}}

{{#if this.model.imgSrc}}
<meta property="og:image" content={{this.model.imgSrc}} />
{{/if}}
<meta property="og:image" content="https://helios.hashicorp.design/assets/logos/share-card.jpg" />
Copy link
Collaborator

@Dhaulagiri Dhaulagiri Jan 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A side effect of this change is that we are no longer using the logic defined here to update the image where we have a more specific one defined for things like components or foundations

Copy link
Contributor Author

@didoo didoo Jan 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #1158 to take into account also this logic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhaulagiri on a side note: that's why I didn't like the idea of having the config data in the environment.js file (even it's an Ember pattern). Because now things/logic/definitions are scattered around in multiple places, and one needs to know it, and know where, otherwise some pieces are lost (like in this case).


{{! END OPENGRAPH }}

{{! BEGIN TWITTER }}

<meta name="twitter:card" content="summary_large_image" />

{{#if this.model.imgSrc}}
<meta name="twitter:image" content={{this.model.imgSrc}} />
{{/if}}
{{! template-lint-disable no-forbidden-elements no-potential-path-strings }}
<meta name="twitter:site" content="@HashiCorp" />
<meta name="twitter:image" content="https://helios.hashicorp.design/assets/logos/share-card.jpg" />

{{#if this.model.title}}
<meta name="twitter:title" content={{this.model.title}} />
Expand All @@ -64,8 +61,4 @@ We've made some small customizations to simplify this compared to the default te
<meta name="twitter:description" content={{this.model.description}} />
{{/if}}

{{#if this.model.twitterUsername}}
<meta name="twitter:site" content={{this.model.twitterUsername}} />
{{/if}}

{{! END TWITTER }}
2 changes: 0 additions & 2 deletions website/config/environment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ module.exports = function (environment) {
siteName: 'Helios Design System',
title: 'Helios Design System',
url: 'https://helios.hashicorp.design',
imgSrc: 'https://helios.hashicorp.design/assets/logos/share-card.jpg',
twitterUsername: '@HashiCorp',
},
};

Expand Down