Skip to content

HDS-1383 Add meta tag for twitter site #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2023
Merged

HDS-1383 Add meta tag for twitter site #1032

merged 1 commit into from
Jan 30, 2023

Conversation

@KristinLBradley
Copy link
Contributor

@KristinLBradley KristinLBradley commented Jan 9, 2023 •
edited
Loading

📌 Summary

Fix image preview for website links shared in Twitter.

Preview: https://hds-website-git-hds-1383-twitter-preview-hashicorp.vercel.app/
Check Twitter share image: https://socialsharepreview.com/

🔗 External links

Jira ticket: HDS-1383

👀 Reviewer's checklist:

  • +1 Percy if applicable
  • Confirm that PR has a changelog update via Changesets if needed

💬 Please consider using conventional comments when reviewing this PR.

@vercel
Copy link

vercel bot commented Jan 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hds-components ✅ Ready (Inspect) Visit Preview Jan 30, 2023 at 8:48PM (UTC)
hds-flight-website ✅ Ready (Inspect) Visit Preview Jan 30, 2023 at 8:48PM (UTC)
hds-website ✅ Ready (Inspect) Visit Preview Jan 30, 2023 at 8:48PM (UTC)

KristinLBradley
KristinLBradley commented Jan 9, 2023
View reviewed changes
@KristinLBradley KristinLBradley requested a review from a team January 9, 2023 20:11
@vercel vercel bot temporarily deployed to Preview – hds-flight-website January 9, 2023 20:13 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components January 9, 2023 20:15 Inactive
Dhaulagiri
Dhaulagiri reviewed Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@Dhaulagiri Dhaulagiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KristinLBradley does this work for you? I tried using the preview app against twitter and the card's preview image is still blank.

If this does work, I added a suggestion for making this more consistent with how ember-meta works for other content like this.

MelSumner
MelSumner reviewed Jan 9, 2023
View reviewed changes
MelSumner
MelSumner reviewed Jan 9, 2023
View reviewed changes
@vercel vercel bot temporarily deployed to Preview – hds-components January 9, 2023 21:30 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website January 9, 2023 21:30 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website January 9, 2023 21:44 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components January 9, 2023 21:44 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website January 9, 2023 21:48 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components January 9, 2023 21:49 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components January 9, 2023 22:56 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website January 9, 2023 22:57 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website January 9, 2023 23:06 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components January 9, 2023 23:06 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website January 9, 2023 23:13 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components January 9, 2023 23:14 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website January 10, 2023 00:09 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components January 10, 2023 00:09 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components January 26, 2023 00:50 Inactive
@KristinLBradley
Copy link
Contributor Author

KristinLBradley commented Jan 26, 2023 •
edited
Loading

@Dhaulagiri I still haven't figured this out but would it be worthwhile to merge what I've done so far and then keep iterating after that? I at least reordered and cleaned some things up and added a hard-coded url for the public site.

@vercel vercel bot temporarily deployed to Preview – hds-flight-website January 27, 2023 19:03 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components January 27, 2023 19:03 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website January 30, 2023 16:46 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components January 30, 2023 16:47 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website January 30, 2023 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components January 30, 2023 17:02 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website January 30, 2023 20:04 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components January 30, 2023 20:04 Inactive
@alex-ju alex-ju force-pushed the hds-1383-twitter-preview branch from 026c38e to 9e11751 Compare January 30, 2023 20:10
@vercel vercel bot temporarily deployed to Preview – hds-components January 30, 2023 20:13 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website January 30, 2023 20:13 Inactive
@alex-ju
Copy link
Member

alex-ju commented Jan 30, 2023

@KristinLBradley I did a squash merge (on a separate branch) to obtain a single commit for all this work, then I force-pushed that commit over the existing changes to overcome the merge limitations. Please check the end result – it should be the same.

@didoo
Updated meta tags for Twitter
a94be46 
commit 06b9c9d
Author: Kristin Bradley <[email protected]>
Date:   Mon Jan 30 08:59:17 2023 -0800

    HDS-1383 Use full url in img variable instead of concatenating

commit 41a1975
Merge: 0b7d104 7dbf9e1
Author: Kristin Bradley <[email protected]>
Date:   Mon Jan 30 08:43:50 2023 -0800

    Merge branch 'main' into hds-1383-twitter-preview

commit 0b7d104
Merge: 0eb5686 3a57cdd
Author: Kristin Bradley <[email protected]>
Date:   Fri Jan 27 11:00:48 2023 -0800

    Merge branch 'main' into hds-1383-twitter-preview

commit 0eb5686
Author: Kristin Bradley <[email protected]>
Date:   Wed Jan 25 16:47:32 2023 -0800

    HDS-1383 Add public site url

commit acfef3e
Merge: ceb99d5 b3f5583
Author: Kristin Bradley <[email protected]>
Date:   Wed Jan 25 16:25:27 2023 -0800

    Merge branch 'main' into hds-1383-twitter-preview

    # Conflicts:
    #	website/config/environment.js

commit ceb99d5
Merge: 87a26f8 636a9f1
Author: Kristin Bradley <[email protected]>
Date:   Thu Jan 12 13:41:21 2023 -0800

    Merge branch 'main' into hds-1383-twitter-preview

commit 87a26f8
Author: Kristin Bradley <[email protected]>
Date:   Thu Jan 12 13:32:37 2023 -0800

    HDS-1383 Try renamining share image as a test

commit 0a485ec
Author: Kristin Bradley <[email protected]>
Date:   Thu Jan 12 12:01:29 2023 -0800

    HDS-1383 Add hard-coded url to test

commit 42f04ad
Merge: b68c37f 53b0ea8
Author: Kristin Bradley <[email protected]>
Date:   Thu Jan 12 08:15:40 2023 -0800

    Merge branch 'main' into hds-1383-twitter-preview

commit b68c37f
Author: Kristin Bradley <[email protected]>
Date:   Tue Jan 10 13:37:53 2023 -0800

    HDS-1383 Fix meta tag for og url

commit 17b0171
Merge: 8cdce1d f543893
Author: Kristin Bradley <[email protected]>
Date:   Tue Jan 10 13:18:47 2023 -0800

    Merge branch 'main' into hds-1383-twitter-preview

commit 8cdce1d
Author: Kristin Bradley <[email protected]>
Date:   Tue Jan 10 09:39:03 2023 -0800

    HDS-1383 Delete commented out meta tags

commit 06848e0
Author: Kristin Bradley <[email protected]>
Date:   Mon Jan 9 16:12:57 2023 -0800

    HDS-1383 Add test img url

commit 455a8cb
Author: Kristin Bradley <[email protected]>
Date:   Mon Jan 9 16:06:50 2023 -0800

    HDS-1383 Test reordering and commnting out some meta tags

commit 4cc0353
Author: Kristin Bradley <[email protected]>
Date:   Mon Jan 9 15:11:17 2023 -0800

    HDS-1383 Fix broken imag url

commit c830695
Author: Kristin Bradley <[email protected]>
Date:   Mon Jan 9 15:04:18 2023 -0800

    HDS-1383 Fix linter bug

commit 5be99a9
Author: Kristin Bradley <[email protected]>
Date:   Mon Jan 9 14:54:23 2023 -0800

    HDS-1383 Test using ful url for image

commit ecd9c1e
Author: Kristin Bradley <[email protected]>
Date:   Mon Jan 9 13:46:42 2023 -0800

    HDS-1383 Fix linter errors

commit 0b6bf2f
Author: Kristin Bradley <[email protected]>
Date:   Mon Jan 9 13:42:22 2023 -0800

    HDS-1383 Make updates to meta tags from feedback

commit c0d6a76
Author: Kristin Bradley <[email protected]>
Date:   Mon Jan 9 13:27:57 2023 -0800

    HDS-1383 Change order of meta tags

commit 59a2bea
Author: Kristin Bradley <[email protected]>
Date:   Mon Jan 9 12:11:12 2023 -0800

    HDS-1383 delete blank line

commit da1ae52
Author: Kristin Bradley <[email protected]>
Date:   Mon Jan 9 12:09:41 2023 -0800

    delete added tag

commit 5dadcc9
Author: Kristin Bradley <[email protected]>
Date:   Mon Jan 9 12:02:24 2023 -0800

    HDS-1383 Add meta tag for twitter site
@didoo didoo force-pushed the hds-1383-twitter-preview branch from 9e11751 to a94be46 Compare January 30, 2023 20:45
didoo
didoo approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KristinLBradley I think we can merge this PR as is now, and then we can see if/how it works in production, and if necessary open a new PR to refine things

@vercel vercel bot temporarily deployed to Preview – hds-flight-website January 30, 2023 20:48 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components January 30, 2023 20:48 Inactive
@KristinLBradley KristinLBradley merged commit d7210a3 into main Jan 30, 2023
@KristinLBradley KristinLBradley deleted the hds-1383-twitter-preview branch January 30, 2023 20:59
This was referenced Jan 30, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dhaulagiri Dhaulagiri Dhaulagiri left review comments

@MelSumner MelSumner MelSumner left review comments

@didoo didoo didoo approved these changes

Assignees

No one assigned

Labels

docs-website Content updates to the documentation website

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KristinLBradley @alex-ju @didoo @Dhaulagiri @MelSumner