Skip to content

HDS-1383 Add meta tag for twitter site #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2023
Merged

HDS-1383 Add meta tag for twitter site #1032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions website/app/templates/head.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ We've made some small customizations to simplify this compared to the default te

{{#if this.model.url}}
<link rel="canonical" href={{this.model.url}} />
<meta property="og:url" content={{this.model.url}} />
{{/if}}

{{! END GENERAL }}
Expand All @@ -27,6 +26,10 @@ We've made some small customizations to simplify this compared to the default te
<meta property="og:site_name" content={{this.model.siteName}} />
{{/if}}

{{#if this.model.url}}
<meta property="og:url" content={{this.model.url}} />
{{/if}}

{{#if this.model.title}}
<meta property="og:title" content={{this.model.title}} />
{{/if}}
Expand All @@ -37,14 +40,13 @@ We've made some small customizations to simplify this compared to the default te

{{#if this.model.imgSrc}}
<meta property="og:image" content={{this.model.imgSrc}} />
<meta property="og:image:type" content="image/jpg" />
{{/if}}

{{! END OPENGRAPH }}

{{! BEGIN TWITTER }}

<meta name="twitter:card" content="summary" />
<meta name="twitter:card" content="summary_large_image" />

{{#if this.model.imgSrc}}
<meta name="twitter:image" content={{this.model.imgSrc}} />
Expand All @@ -62,4 +64,8 @@ We've made some small customizations to simplify this compared to the default te
<meta name="twitter:description" content={{this.model.description}} />
{{/if}}

{{#if this.model.twitterUsername}}
<meta name="twitter:site" content={{this.model.twitterUsername}} />
{{/if}}

{{! END TWITTER }}
5 changes: 3 additions & 2 deletions website/config/environment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,9 @@ module.exports = function (environment) {
'The Helios Design System from HashiCorp provides the open source building blocks to design and implement consistent, accessible, and delightful product experiences.',
siteName: 'Helios Design System',
title: 'Helios Design System',
imgSrc: '/assets/logos/share-card.jpg',
url: 'https://helios.hashicorp.design/',
url: 'https://helios.hashicorp.design',
imgSrc: 'https://helios.hashicorp.design/assets/logos/share-card.jpg',
twitterUsername: '@HashiCorp',
},
};

Expand Down