[NET-6232] docs: Update consul-k8s Helm chart docs (1.2.x)

[zalimeni]

Sync docs for recent changes to the Helm chart from consul-k8s.

Description

Updates docs for backport of hashicorp/consul-k8s#3180 following #19577.

Also includes another minor previous change that wasn't synced.

PR Checklist

• updated test coverage
• external facing docs updated
• appropriate backport labels added
• not a security concern

[david-yu]

@zalimeni I didn't realize these merged right after approval so approved one of these PRs. These are docs for un-released functionality is that correct? If so, we should only merge upon release.

[david-yu]

Also typically it is a customary for the release engineer to run the make-docs make command to help create a PR against the consul core repo based on the Helm chart comments, not sure if that is a better way to handle things.

[zalimeni]

@zalimeni I didn't realize these merged right after approval so approved one of these PRs. These are docs for un-released functionality is that correct? If so, we should only merge upon release.

@david-yu good point, that was my mistake 🤦🏻‍♂️ I hadn't considered that after #19577 was merged and misinterpreted your backport label addition there; I really should have only synced over the old content that was missing.

I'll open a PR to revert the merged change, and update this one to just address the un-synced content, then allow the normal process to take care of the new docs. (TIL we had that in place already, though I should have guessed so)

Also typically it is a customary for the release engineer to run the make-docs make command to help create a PR against the consul core repo based on the Helm chart comments, not sure if that is a better way to handle things.

Makes sense. I did use make gen-helm-docs consul=../consul from consul-k8s to sync these, but I agree it's probably best to let this remain part of the release process w.r.t. timing.

[david-yu]

Thanks I appreciate the follow up here, sorry for leading you originally down the wrong path.

[zalimeni]

@david-yu of course, thanks for catching and educating me!

[zalimeni]

Ok @david-yu , this one is ready for review.