Skip to content

[NET-6232] Helm Chart: Support StatefulSet PVC retention#3180

Merged
zalimeni merged 1 commit intomainfrom
zalimeni/alemuro/3101-support-statefulset-pvc-retain
Nov 8, 2023
Merged

[NET-6232] Helm Chart: Support StatefulSet PVC retention#3180
zalimeni merged 1 commit intomainfrom
zalimeni/alemuro/3101-support-statefulset-pvc-retain

Conversation

@zalimeni
Copy link
Copy Markdown
Member

@zalimeni zalimeni commented Nov 7, 2023

PR to run CI and then merge the following community contribution by @alemuro: #3102

Refer to that PR for discussion and examples.

@zalimeni zalimeni force-pushed the zalimeni/alemuro/3101-support-statefulset-pvc-retain branch from e0efe5d to 622ffa9 Compare November 7, 2023 21:13
@zalimeni zalimeni added backport/1.1.x Backport to release/1.1.x branch backport/1.2.x This release branch is no longer active. backport/1.3.x This release branch is no longer active. labels Nov 7, 2023
@zalimeni zalimeni marked this pull request as ready for review November 7, 2023 21:22
Copy link
Copy Markdown
Contributor

@david-yu david-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming tests pass

@zalimeni
Copy link
Copy Markdown
Member Author

zalimeni commented Nov 8, 2023

Rebased to pick up fix from #3172, which should address unit test failure

Add new variable on the Helm chart to define the PVC retention policy for
the StatefulSet
@zalimeni zalimeni force-pushed the zalimeni/alemuro/3101-support-statefulset-pvc-retain branch from 622ffa9 to 3cddf31 Compare November 8, 2023 14:44
@zalimeni zalimeni enabled auto-merge (squash) November 8, 2023 14:59
@zalimeni zalimeni merged commit 39aae71 into main Nov 8, 2023
@zalimeni zalimeni deleted the zalimeni/alemuro/3101-support-statefulset-pvc-retain branch November 8, 2023 15:17
@zalimeni zalimeni changed the title [NET-5025] Helm Chart: Support StatefulSet PVC retention [NET-6232] Helm Chart: Support StatefulSet PVC retention Nov 8, 2023
sarahalsmiller pushed a commit that referenced this pull request Jan 5, 2024
Helm Chart: Support StatefulSet PVC retention

Add new variable on the Helm chart to define the PVC retention policy for
the StatefulSet

Co-authored-by: Aleix Murtra <alemurbcn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.1.x Backport to release/1.1.x branch backport/1.2.x This release branch is no longer active. backport/1.3.x This release branch is no longer active.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants