Skip to content

[Backport] Rename hcp-metrics-collector to consul-telemetry-collector (#17327)#17412

Merged
Achooo merged 1 commit intorelease/1.15.xfrom
backport/f/metrics-collector-rename/achooo-manual
May 19, 2023
Merged

[Backport] Rename hcp-metrics-collector to consul-telemetry-collector (#17327)#17412
Achooo merged 1 commit intorelease/1.15.xfrom
backport/f/metrics-collector-rename/achooo-manual

Conversation

@Achooo
Copy link
Contributor

@Achooo Achooo commented May 18, 2023

  • Rename hcp-metrics-collector to consul-telemetry-collector

  • Fix docs

  • Fix doc comment


Description

Backporting manually the changes in PR #17327
The backport PR that failed: #17386

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

* Rename hcp-metrics-collector to consul-telemetry-collector

* Fix docs

* Fix doc comment

---------

Co-authored-by: Ashvitha Sridharan <ashvitha.sridharan@hashicorp.com>
@Achooo Achooo requested a review from a team as a code owner May 18, 2023 20:31
@github-actions github-actions bot added theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface theme/envoy/xds Related to Envoy support type/docs Documentation needs to be created/updated/clarified labels May 18, 2023
@Achooo Achooo requested a review from curtbushko May 18, 2023 20:31
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Achooo
Copy link
Contributor Author

Achooo commented May 18, 2023

@curtbushko lightning speed review, thanks! ⚡

@Achooo Achooo merged commit 87d3f45 into release/1.15.x May 19, 2023
@Achooo Achooo deleted the backport/f/metrics-collector-rename/achooo-manual branch May 19, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface theme/envoy/xds Related to Envoy support type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants